Differential D6668

sourceforge lister: Fix type
AbandonedPublicDraft
Actions

Authored by ardumont on Nov 23 2021, 10:52 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

This is another proposed implementation.
Opening in a new diff for comparison.

This may also fix the master build [1]

[1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLS/job/tests/1625/console

Diff Detail

Repository

rDLS Listers

Branch

fix-sourceforge-type

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25111
Build 39235: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39234: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	46 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.sourceforge.tests.test_lister::test_sourceforge_lister_full swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f03deda2ba8> requests_mock = <requests_mock.mocker.Mocker object at 0x7f03deda2748> datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/sourceforge/tests/data'
	52 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.sourceforge.tests.test_lister::test_sourceforge_lister_incremental swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f03dfb11da0> requests_mock = <requests_mock.mocker.Mocker object at 0x7f03dfb112e8> datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/sourceforge/tests/data'
	39 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.sourceforge.tests.test_lister::test_sourceforge_lister_project_error[403] datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/sourceforge/tests/data' swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f03deb6c940> requests_mock = <requests_mock.mocker.Mocker object at 0x7f03deb6c278>
	46 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.sourceforge.tests.test_lister::test_sourceforge_lister_project_error[404] datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/sourceforge/tests/data' swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f03deb76b70> requests_mock = <requests_mock.mocker.Mocker object at 0x7f03deb76748>
	46 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.sourceforge.tests.test_lister::test_sourceforge_lister_project_error[500] datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/sourceforge/tests/data' swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f03dec8ffd0> requests_mock = <requests_mock.mocker.Mocker object at 0x7f03ddea08d0>
		View Full Test Results (8 Failed · 181 Passed)

Event Timeline

ardumont created this revision.Nov 23 2021, 10:52 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 23 2021, 10:52 AM

ardumont mentioned this in D6666: sourceforge lister: Fix type.Nov 23 2021, 10:53 AM

Build has FAILED

Patch application report for D6668 (id=24235)

Rebasing onto 97553d8984...

Current branch diff-target is up to date.

Changes applied before test

commit 874173676007b1c757ad384357d6df8651bca0f1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 23 10:13:19 2021 +0100

    sourceforge lister: Fix type
    
    This fixes the master build [1]
    
    [1] https://jenkins.softwareheritage.org/view/swh-draft/job/DLS/job/tests/1625/console

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/414/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/414/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 23 2021, 10:55 AM

Harbormaster failed remote builds in B25111: Diff 24235!

ardumont edited the summary of this revision. (Show Details)Nov 23 2021, 11:00 AM

D6666 is enough and landed.
So closing.