Differential D6631

utils: Add types and let log instruction do the formatting
ClosedPublic
Actions

Authored by ardumont on Nov 10 2021, 10:19 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDBASE1f1bdad89936: utils: Add types and let log instruction do the formatting

Summary

more types

Test Plan

tox (happy)

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24975
Build 39032: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39031: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 10 2021, 10:19 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 10 2021, 10:19 AM

Build is green

Patch application report for D6631 (id=24100)

Rebasing onto 5063082e7d...

Current branch diff-target is up to date.

Changes applied before test

commit aebf4738138bcd3163b8e4b0738834d77a4b40e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 10 10:18:35 2021 +0100

    utils: Add types and let log instruction do the formatting

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/612/ for more details.

Harbormaster completed remote builds in B24975: Diff 24100.Nov 10 2021, 10:21 AM

ardumont requested review of this revision.Nov 10 2021, 10:21 AM

vlorentz accepted this revision.Nov 10 2021, 11:16 AM

This revision is now accepted and ready to land.Nov 10 2021, 11:16 AM

@vlorentz, thx, I'll let you land your pile of diffs first ;)

Thanks! :D

Rebase

Build is green

Patch application report for D6631 (id=24119)

Rebasing onto 059c71b673...

Current branch diff-target is up to date.

Changes applied before test

commit 1f1bdad8993688e2132b0930c837d7dc9cffa1fc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 10 10:18:35 2021 +0100

    utils: Add types and let log instruction do the formatting

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/613/ for more details.

Harbormaster completed remote builds in B24998: Diff 24119.Nov 10 2021, 2:37 PM

Closed by commit rDLDBASE1f1bdad89936: utils: Add types and let log instruction do the formatting (authored by ardumont). · Explain WhyNov 10 2021, 2:39 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASE1f1bdad89936: utils: Add types and let log instruction do the formatting.