Differential D6627

Allow release authors to be None even if the date is not None
AbandonedPublic
Actions

Authored by vlorentz on Nov 9 2021, 3:46 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

I don't see any reason for this restriction, release dates are usually
available info, while authors are not defined.

Package loaders worked around this restriction by setting
the empty string as author, anyway...

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24949
Build 38988: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38987: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 9 2021, 3:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 9 2021, 3:46 PM

Build is green

Patch application report for D6627 (id=24074)

Rebasing onto 2ffe5dba84...

Current branch diff-target is up to date.

Changes applied before test

commit 39bcfc05061f6312323a3698559a5b064947a031
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 9 15:45:18 2021 +0100

    Allow release authors to be None even if the date is not None
    
    I don't see any reason for this restriction, release dates are usually
    available info, while authors are not defined.
    
    Package loaders worked around this restriction by setting
    the empty string as author, anyway...

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/402/ for more details.

Harbormaster completed remote builds in B24949: Diff 24074.Nov 9 2021, 3:48 PM

vlorentz requested review of this revision.Nov 9 2021, 3:48 PM

vlorentz mentioned this in D6628: Allow release authors to be None even if the date is not None.Nov 9 2021, 3:52 PM

vlorentz added a parent revision: D6628: Allow release authors to be None even if the date is not None.Nov 9 2021, 3:53 PM

vlorentz added a child revision: D6629: Package loader: Uniformize author and message.Nov 9 2021, 4:32 PM

Can you add a test that the manifest renders properly (with the date) in that case?

abandonning this, as there isn't a good way to serialize manifests with a date but no author