Paths

Table of Contentst

Differential D6587

Improve docs rendering for recurrent visits scheduler
ClosedPublic
Actions

Authored by olasd on Oct 29 2021, 3:46 PM.

Details

Reviewers

vlorentz

Commits

rDSCH7f434c3fbf06: Improve docs rendering for recurrent visits scheduler

Summary

as mentioned by @vlorentz in the original diff

Test Plan

rendered with tox -e sphinx

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24825
Build 38766: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38765: arc lint + arc unit

Event Timeline

olasd created this revision.Oct 29 2021, 3:46 PM

Build is green

Patch application report for D6587 (id=23948)

Rebasing onto 50d7fd7ff4...

Current branch diff-target is up to date.

Changes applied before test

commit 7f434c3fbf0649519fce610f8c92cba70095693e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Oct 29 15:44:56 2021 +0200

    Improve docs rendering for recurrent visits scheduler

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/493/ for more details.

Harbormaster completed remote builds in B24825: Diff 23948.Oct 29 2021, 3:48 PM

olasd requested review of this revision.Oct 29 2021, 3:48 PM

olasd added a child revision: D6588: recurrent visits: use policy weights instead of ratios.Oct 29 2021, 4:02 PM

vlorentz accepted this revision.Nov 3 2021, 3:25 PM

vlorentz added inline comments.

swh/scheduler/celery_backend/recurrent_visits.py
89	typo? same comment below

This revision is now accepted and ready to land.Nov 3 2021, 3:25 PM

olasd added inline comments.Nov 5 2021, 11:30 AM

swh/scheduler/celery_backend/recurrent_visits.py
89	Nope, that's not a typo. This makes sphinx shorten the link text to just the class name, instead of the fully qualified class name.

Closed by commit rDSCH7f434c3fbf06: Improve docs rendering for recurrent visits scheduler (authored by olasd). · Explain WhyNov 5 2021, 12:01 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSCH7f434c3fbf06: Improve docs rendering for recurrent visits scheduler.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

scheduler/

celery_backend/

recurrent_visits.py

50 lines

80%

Diff 23948

View Options

swh/scheduler/celery_backend/recurrent_visits.py

Improve docs rendering for recurrent visits schedulerClosedPublicActions