Page MenuHomeSoftware Heritage

deposit: Remove 'parent' deposit
ClosedPublic

Authored by vlorentz on Oct 21 2021, 2:36 PM.

Details

Summary

The parent is computed by the deposit as the revision of the latest deposit
in the same origin before the current one.
Therefore, it is redundant, as it can be recomputed from metadata
+ revision date.

This is a preliminary change needed to make package loaders produce
releases instead of revisions (T1260), as releases don't have parent relationships

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6529 (id=23738)

Rebasing onto 9d89bf86b0...

Current branch diff-target is up to date.
Changes applied before test
commit f6905cdf547c8a1325fe8b3a0cbf6cb2373031a6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 21 14:35:47 2021 +0200

    deposit: Remove 'parent' deposit
    
    The parent is computed by the deposit as the revision of the latest deposit
    in the same origin before the current one.
    Therefore, it is redundant, as it can be recomputed from metadata
    + revision date.
    
    This is a preliminary change needed to make package loaders produce
    releases instead of revisions, as releases don't have parent relationships

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/583/ for more details.

ardumont added 1 blocking reviewer(s): moranegg.

Mmmm, ok i guess. I don't recall the reason that made it that way initially.

And what you said in the description about redundancy and recomputation makes sense.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 21 2021, 4:21 PM
This revision was automatically updated to reflect the committed changes.