Differential D6525

Use get_objstorage in seaweedfs tests instead of direct class instanciation
ClosedPublic
Actions

Authored by douardda on Oct 21 2021, 1:06 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDOBJS82d9714b0ae5: Use get_objstorage in seaweedfs tests instead of direct class

Summary

Depends on D6524

Diff Detail

Repository

rDOBJS Object storage

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 24611
Build 38406: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38405: arc lint + arc unit

Event Timeline

douardda created this revision.Oct 21 2021, 1:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 21 2021, 1:06 PM

douardda added a child revision: D6526: Reorganise the seaweedfs backend in a subpackage.Oct 21 2021, 1:07 PM

Build is green

Patch application report for D6525 (id=23721)

Could not rebase; Attempt merge onto 6269067ca7...

Updating 6269067..82d9714
Fast-forward
 swh/objstorage/factory.py                         | 11 +++++++++--
 swh/objstorage/tests/test_objstorage_seaweedfs.py |  6 ++++--
 2 files changed, 13 insertions(+), 4 deletions(-)

Changes applied before test

commit 82d9714b0ae5a3687da331c2198010b8d62c8c0b
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Oct 21 09:58:06 2021 +0200

    Use get_objstorage in seaweedfs tests instead of direct class
    instanciation

commit 38c02dcfae2baa141c7149d5556123fe7341b54b
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Oct 21 09:55:50 2021 +0200

    Add support for deprecation of objstorage cls in factory
    
    and deprecate "weed" in favor of "seaweedfs".

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/59/ for more details.

Harbormaster completed remote builds in B24611: Diff 23721.Oct 21 2021, 1:09 PM

douardda requested review of this revision.Oct 21 2021, 1:09 PM

vlorentz accepted this revision.Oct 21 2021, 1:19 PM

This revision is now accepted and ready to land.Oct 21 2021, 1:19 PM

Closed by commit rDOBJS82d9714b0ae5: Use get_objstorage in seaweedfs tests instead of direct class (authored by douardda). · Explain WhyOct 21 2021, 2:06 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDOBJS82d9714b0ae5: Use get_objstorage in seaweedfs tests instead of direct class.