Page MenuHomeSoftware Heritage

git: Deprecate no longer running nor used code
ClosedPublic

Authored by ardumont on Oct 20 2021, 9:50 AM.

Details

Summary

I can be wrong so please do tell what's what.

For my part, it'd be good we only have one instance of git loader to avoid asking
ourselves all the time what's the canonical implementation.

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24536
Build 38283: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38282: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2021, 9:51 AM
Harbormaster failed remote builds in B24536: Diff 23645!

Update readme reference as well.

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2021, 9:53 AM
Harbormaster failed remote builds in B24537: Diff 23646!

Build has FAILED

Patch application report for D6513 (id=23646)

Rebasing onto 0e824769ef...

First, rewinding head to replay your work on top of it...
Applying: git: Deprecate no longer running or used code
Changes applied before test
commit 88a73a47c33a05f31b2f23edb7965cb87a1e4782
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 09:42:54 2021 +0200

    git: Deprecate no longer running or used code

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/147/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/147/console

Add types-deprecated to test deps

Build is green

Patch application report for D6513 (id=23648)

Rebasing onto 0e824769ef...

First, rewinding head to replay your work on top of it...
Applying: git: Deprecate no longer running or used code
Changes applied before test
commit 0bc560763a60225bbda4ba5b8e0c413bcc4cfe67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 09:42:54 2021 +0200

    git: Deprecate no longer running or used code

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/148/ for more details.

vlorentz added a subscriber: vlorentz.

Shouldn't the version be 1.1.4?

This revision is now accepted and ready to land.Oct 20 2021, 10:11 AM

Shouldn't the version be 1.1.4?

1.1.3 maybe (last one is 1.1.2).

nvm that, i was not up-to-date ;)
I'll keep 1.1 though as that's not necessary to give that much details.

Build is green

Patch application report for D6513 (id=23674)

Rebasing onto 0e824769ef...

Current branch diff-target is up to date.
Changes applied before test
commit c843ea5c4b003a9b5a3197e56af049722648a67d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 20 09:42:54 2021 +0200

    git: Deprecate no longer running or used code

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/149/ for more details.