Page MenuHomeSoftware Heritage

converters: Fix detection of tree entries with non-standard commit/tree mode.
ClosedPublic

Authored by vlorentz on Oct 19 2021, 1:59 PM.

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6504 (id=23621)

Rebasing onto 0e824769ef...

Current branch diff-target is up to date.
Changes applied before test
commit ebd24158486d92dd17ebe0dfac0f45ecd5cddfb8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 19 13:59:17 2021 +0200

    converters: Fix detection of tree entries with non-standard commit/tree mode.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/144/ for more details.

ardumont added 1 blocking reviewer(s): olasd.
ardumont added a subscriber: ardumont.

What i understood of this improvment is that only the detection logic of {tree, commit} got improved.
This keeps whatever is ingested with their "non-standard" mode.

Looks fine to me.

You should probably reference the integrity task it's for.

This revision is now accepted and ready to land.Oct 20 2021, 5:13 PM
This revision was landed with ongoing or failed builds.Oct 21 2021, 11:26 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D6504 (id=23714)

Rebasing onto a40f1e00cd...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-150-D6504.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/150/ for more details.