Page MenuHomeSoftware Heritage

assets/admin/origin-save: Enable to add note when rejecting a request
ClosedPublic

Authored by anlambert on Oct 19 2021, 11:20 AM.

Details

Summary

In the save code now administation page, display a new modal when
rejecting a save request enabling to add a rejection note through
the use of a text area.

Default behavior is to enter a custom note but a couple of prefilled
rejection notes can be selected for the following cases:

  • the origin URL is not a repository link
  • the visit type for the origin URL is not valid
  • the origin URL cannot be found

Related to T3256
Related to T3257

Diff Detail

Repository
rDWAPPS Web applications
Branch
save-code-now-rejection-note-ui
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24509
Build 38241: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38240: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D6501 (id=23616)

Rebasing onto 61b80b8b23...

Current branch diff-target is up to date.
Changes applied before test
commit a314f8d0cd234154c4ec9d2721f11125bd710951
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 15 16:13:38 2021 +0200

    assets/admin/origin-save: Enable to add note when rejecting a request
    
    In the save code now administation page, display a new modal when
    rejecting a save request enabling to add a rejection note through
    the use of a text area.
    
    Default behavior is to enter a custom note but a couple of prefilled
    rejection notes can be selected for the following cases:
    
      - the origin URL is not a repository link
      - the visit type for the origin URL is not valid
      - the origin URL cannot be found
    
    Related to T3256
    Related to T3257

commit deb77b1c79895c01b5acf7769249dc615ca943d6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 18 15:37:34 2021 +0200

    Makefile.local: Remove correct sqlite tests database
    
    File has been renamed in a recent commit.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1188/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1188/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 19 2021, 11:35 AM
Harbormaster failed remote builds in B24507: Diff 23616!

Build is green

Patch application report for D6501 (id=23618)

Rebasing onto 61b80b8b23...

Current branch diff-target is up to date.
Changes applied before test
commit c0d56bf7840956f9d4deab2d4be5611f157cb393
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 15 16:13:38 2021 +0200

    assets/admin/origin-save: Enable to add note when rejecting a request
    
    In the save code now administation page, display a new modal when
    rejecting a save request enabling to add a rejection note through
    the use of a text area.
    
    Default behavior is to enter a custom note but a couple of prefilled
    rejection notes can be selected for the following cases:
    
      - the origin URL is not a repository link
      - the visit type for the origin URL is not valid
      - the origin URL cannot be found
    
    Related to T3256
    Related to T3257

commit deb77b1c79895c01b5acf7769249dc615ca943d6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 18 15:37:34 2021 +0200

    Makefile.local: Remove correct sqlite tests database
    
    File has been renamed in a recent commit.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1190/ for more details.

This revision is now accepted and ready to land.Oct 19 2021, 3:42 PM

Rebase and fix a couple of typos in cypress test comments

Build is green

Patch application report for D6501 (id=23626)

Rebasing onto b72fd7f917...

Current branch diff-target is up to date.
Changes applied before test
commit 6c2792e9090f72dde075d96380605eb7269b9fac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 15 16:13:38 2021 +0200

    assets/admin/origin-save: Enable to add note when rejecting a request
    
    In the save code now administation page, display a new modal when
    rejecting a save request enabling to add a rejection note through
    the use of a text area.
    
    Default behavior is to enter a custom note but a couple of prefilled
    rejection notes can be selected for the following cases:
    
      - the origin URL is not a repository link
      - the visit type for the origin URL is not valid
      - the origin URL cannot be found
    
    Related to T3256
    Related to T3257

commit 9cf83ddceafe502c9aca8b5972805f38924f2d97
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 18 15:37:34 2021 +0200

    Makefile.local: Remove correct sqlite tests database
    
    File has been renamed in a recent commit.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1193/ for more details.