origin-save: Enable to add note when rejecting a request
ClosedPublic
Actions

Authored by anlambert on Oct 19 2021, 11:20 AM.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T3256: Propose reason for rejecting a save code now
T3257: Template the save code now rejection reason to ease operator workflow

Commits

rDWAPPS6c2792e9090f: assets/admin/origin-save: Enable to add note when rejecting a request
rDWAPPS9cf83ddceafe: Makefile.local: Remove correct sqlite tests database

Summary

In the save code now administation page, display a new modal when
rejecting a save request enabling to add a rejection note through
the use of a text area.

Default behavior is to enter a custom note but a couple of prefilled
rejection notes can be selected for the following cases:

the origin URL is not a repository link
the visit type for the origin URL is not valid
the origin URL cannot be found

Related to T3256
Related to T3257

Diff Detail

Repository

rDWAPPS Web applications

Branch

save-code-now-rejection-note-ui

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24507
Build 38237: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38236: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	3,533 ms	Jenkins > should show only user requests when filter is activated::Tests / Cypress tests / Run cypress tests / Origin Save Tests should show only user requests when filter is activated AssertionError: expected 3 to equal 2 at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-save.spec.js:534:30)
	1,103 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
	500 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_authorized_origin_url
	270 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_unauthorized_origin_url
	312 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_reject_pending_save_request
		View Full Test Results (1 Failed · 756 Passed · 5 Skipped)

Event Timeline

anlambert created this revision.Oct 19 2021, 11:20 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 19 2021, 11:20 AM

anlambert added a child revision: D6502: assets/origin-save: Display rejection reason in request info popover.Oct 19 2021, 11:21 AM

Build has FAILED

Patch application report for D6501 (id=23616)

Rebasing onto 61b80b8b23...

Current branch diff-target is up to date.

Changes applied before test

commit a314f8d0cd234154c4ec9d2721f11125bd710951
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 15 16:13:38 2021 +0200

    assets/admin/origin-save: Enable to add note when rejecting a request
    
    In the save code now administation page, display a new modal when
    rejecting a save request enabling to add a rejection note through
    the use of a text area.
    
    Default behavior is to enter a custom note but a couple of prefilled
    rejection notes can be selected for the following cases:
    
      - the origin URL is not a repository link
      - the visit type for the origin URL is not valid
      - the origin URL cannot be found
    
    Related to T3256
    Related to T3257

commit deb77b1c79895c01b5acf7769249dc615ca943d6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 18 15:37:34 2021 +0200

    Makefile.local: Remove correct sqlite tests database
    
    File has been renamed in a recent commit.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1188/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1188/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 19 2021, 11:35 AM

Harbormaster failed remote builds in B24507: Diff 23616!

Fix cypress test

Build is green

Patch application report for D6501 (id=23618)

Rebasing onto 61b80b8b23...

Current branch diff-target is up to date.

Changes applied before test

commit c0d56bf7840956f9d4deab2d4be5611f157cb393
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 15 16:13:38 2021 +0200

    assets/admin/origin-save: Enable to add note when rejecting a request
    
    In the save code now administation page, display a new modal when
    rejecting a save request enabling to add a rejection note through
    the use of a text area.
    
    Default behavior is to enter a custom note but a couple of prefilled
    rejection notes can be selected for the following cases:
    
      - the origin URL is not a repository link
      - the visit type for the origin URL is not valid
      - the origin URL cannot be found
    
    Related to T3256
    Related to T3257

commit deb77b1c79895c01b5acf7769249dc615ca943d6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 18 15:37:34 2021 +0200

    Makefile.local: Remove correct sqlite tests database
    
    File has been renamed in a recent commit.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1190/ for more details.

Harbormaster completed remote builds in B24509: Diff 23618.Oct 19 2021, 12:28 PM

anlambert requested review of this revision.Oct 19 2021, 12:28 PM

anlambert edited the summary of this revision. (Show Details)Oct 19 2021, 12:32 PM

Great!

This revision is now accepted and ready to land.Oct 19 2021, 3:42 PM

Rebase and fix a couple of typos in cypress test comments

Build is green

Patch application report for D6501 (id=23626)

Rebasing onto b72fd7f917...

Current branch diff-target is up to date.

Changes applied before test

commit 6c2792e9090f72dde075d96380605eb7269b9fac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 15 16:13:38 2021 +0200

    assets/admin/origin-save: Enable to add note when rejecting a request
    
    In the save code now administation page, display a new modal when
    rejecting a save request enabling to add a rejection note through
    the use of a text area.
    
    Default behavior is to enter a custom note but a couple of prefilled
    rejection notes can be selected for the following cases:
    
      - the origin URL is not a repository link
      - the visit type for the origin URL is not valid
      - the origin URL cannot be found
    
    Related to T3256
    Related to T3257

commit 9cf83ddceafe502c9aca8b5972805f38924f2d97
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 18 15:37:34 2021 +0200

    Makefile.local: Remove correct sqlite tests database
    
    File has been renamed in a recent commit.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1193/ for more details.

Harbormaster completed remote builds in B24517: Diff 23626.Oct 19 2021, 4:10 PM

Closed by commit rDWAPPS9cf83ddceafe: Makefile.local: Remove correct sqlite tests database (authored by anlambert). · Explain WhyOct 19 2021, 4:12 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS9cf83ddceafe: Makefile.local: Remove correct sqlite tests database.

anlambert added a commit: rDWAPPS6c2792e9090f: assets/admin/origin-save: Enable to add note when rejecting a request.