Makefile: Drop unused pdf generation from the build
ClosedPublic
Actions

Authored by ardumont on Oct 18 2021, 10:55 AM.

Details

Reviewers

Group Reviewers

System administrators
Reviewers

Maniphest Tasks

T3665: Fix swh-docs builds (publish and dev)

Commits

rDFUSEa300deca15eb: docs/images/Makefile: Drop unused pdf generation from the build

Summary

The target is kept so it's still usable if needed. It's dropped from the publish build
as this creates problem otherwise.

Related to T3665

Test Plan

make -C docs html still happy

Diff Detail

Repository

rDFUSE FUSE virtual file system

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 18 2021, 10:55 AM

Build is green

Patch application report for D6493 (id=23589)

Rebasing onto e1dc2d1c89...

Current branch diff-target is up to date.

Changes applied before test

commit 7e2ae231d6e05df6ff1cdce2fecd45dd7d0112d6
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Mon Oct 18 10:52:53 2021 +0200

    docs/images/Makefile: Drop unused pdf generation
    
    It's unused and this creates problem in the publish build.
    
    Related to T3665

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/280/ for more details.

Harbormaster completed remote builds in B24485: Diff 23589.Oct 18 2021, 10:59 AM

ardumont requested review of this revision.Oct 18 2021, 10:59 AM

zack requested changes to this revision.Oct 18 2021, 11:40 AM

zack added a subscriber: zack.

zack added inline comments.

docs/images/Makefile
2	please leave this, just removed it from the all target
8–9	please don't drop this, otherwise it will be annoying to recreate the PDFs when desired
21	PDFs should remain here too, so that if one builds it (on demand), it will be removed upon clean

This revision now requires changes to proceed.Oct 18 2021, 11:40 AM

ok, thanks.

Adapt according to review (commit msg adapted accordingly as well)

ardumont retitled this revision from fuse: docs/images/Makefile: Drop unused pdf generation to fuse: docs/images/Makefile: Drop unused pdf generation from the build.Oct 18 2021, 11:50 AM

ardumont edited the summary of this revision. (Show Details)

Build is green

Patch application report for D6493 (id=23590)

Rebasing onto e1dc2d1c89...

Current branch diff-target is up to date.

Changes applied before test

commit a300deca15ebd5f1e373651fc936486ee69d4b95
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Mon Oct 18 10:52:53 2021 +0200

    docs/images/Makefile: Drop unused pdf generation from the build
    
    The target is kept so it's still usable if needed. It's dropped from the publish build
    as this creates problem otherwise.
    
    Related to T3665

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/281/ for more details.

Harbormaster completed remote builds in B24486: Diff 23590.Oct 18 2021, 11:54 AM

zack accepted this revision.Oct 18 2021, 12:01 PM

This revision is now accepted and ready to land.Oct 18 2021, 12:01 PM

Closed by commit rDFUSEa300deca15eb: docs/images/Makefile: Drop unused pdf generation from the build (authored by ardumont). · Explain WhyOct 18 2021, 12:29 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDFUSEa300deca15eb: docs/images/Makefile: Drop unused pdf generation from the build.