Page MenuHomeSoftware Heritage

assets/origin/bundles: Restore visualizations state on page reload
ClosedPublic

Authored by anlambert on Wed, Oct 6, 3:10 PM.

Details

Summary

Ensure to restore origin visits visualization state (aka visits filtering)
when reloading page.

Depends on D6421

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6422 (id=23340)

Could not rebase; Attempt merge onto c8c0ac1eab...

Updating c8c0ac1e..2bcf33c2
Fast-forward
 assets/src/bundles/origin/utils.js             | 15 ++++++++++++++
 assets/src/bundles/origin/visits-calendar.js   | 28 +++++++++++++-------------
 assets/src/bundles/origin/visits-histogram.js  |  8 +++++---
 assets/src/bundles/origin/visits-reporting.css | 24 +++++++++++++++++++++-
 assets/src/bundles/origin/visits-reporting.js  | 12 ++++++++---
 package.json                                   |  1 +
 yarn.lock                                      |  5 +++++
 7 files changed, 72 insertions(+), 21 deletions(-)
 create mode 100644 assets/src/bundles/origin/utils.js
Changes applied before test
commit 2bcf33c2e527396da9e226f503b236985e2a4f61
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Oct 6 15:08:20 2021 +0200

    assets/origin/bundles: Restore visualizations state on page reload
    
    Ensure to restore origin visits visualization state (aka visits filtering)
    when reloading page.

commit d394d9452dbd9a493507d0514a32904f4e9f2cab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Oct 6 15:04:42 2021 +0200

    assets/bundles/origin: Add missing statuses to visits reporting
    
    Handle "created" and "not_found" statuses in origin visits visualization.
    
    Put visit statuses colors in a dedicated file in order to share them
    between modules.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1143/ for more details.

vlorentz added a subscriber: vlorentz.

ahah, nice!

This revision is now accepted and ready to land.Wed, Oct 6, 3:47 PM