Differential D6418

test_utils.py: Remove incorrect mocks
ClosedPublic
Actions

Authored by vlorentz on Oct 6 2021, 1:11 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP915c877fd7df: test_utils.py: Remove incorrect mocks

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24247
Build 37845: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37844: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 6 2021, 1:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 6 2021, 1:11 PM

vlorentz mentioned this in D6413: Rename imports of swh.model.identifiers to fix deprecation warnings..Oct 6 2021, 1:13 PM

vlorentz added a child revision: D6413: Rename imports of swh.model.identifiers to fix deprecation warnings..Oct 6 2021, 1:13 PM

Build is green

Patch application report for D6418 (id=23334)

Rebasing onto d1b840de26...

Current branch diff-target is up to date.

Changes applied before test

commit 915c877fd7dfdf451169254c2e6c494341a48c6b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Oct 6 13:11:18 2021 +0200

    test_utils.py: Remove incorrect mocks

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/679/ for more details.

Harbormaster completed remote builds in B24247: Diff 23334.Oct 6 2021, 1:14 PM

vlorentz requested review of this revision.Oct 6 2021, 1:14 PM

ok.

i absolutely do not remember what those are.

This revision is now accepted and ready to land.Oct 6 2021, 4:38 PM

Closed by commit rDDEP915c877fd7df: test_utils.py: Remove incorrect mocks (authored by vlorentz). · Explain WhyOct 7 2021, 10:16 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP915c877fd7df: test_utils.py: Remove incorrect mocks.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

deposit/

tests/

test_utils.py

47 lines

100%

Diff 23334

View Options

swh/deposit/tests/test_utils.py

test_utils.py: Remove incorrect mocksClosedPublicActions