Differential D6416

dumb: Handle missing or corrupted pack file
ClosedPublic
Actions

Authored by anlambert on Oct 5 2021, 4:14 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3618: Reschedule loading of dumb git origins submitted to "Save code now" service

Commits

rDLDGd3d60421423a: dumb: Handle missing or corrupted pack file

Summary

Some dumb git servers might reference a no longer existing pack file
while it is possible to fully load a repository without it.

See for instance https://git.zap.org.au/git/console-fonts-utils.git/objects/info/packs
and https://git.zap.org.au/git/console-fonts-utils.git/objects/pack/.

So remove bogus pack file from the global packs list when encountering
such edge case and try to continue the loading anyway.

Related to T3618

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 5 2021, 4:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2021, 4:14 PM

Build is green

Patch application report for D6416 (id=23322)

Rebasing onto 6b21441da6...

Current branch diff-target is up to date.

Changes applied before test

commit d3d60421423a981c82d214a184a59e23d4500532
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 5 16:07:58 2021 +0200

    dumb: Handle missing or corrupted pack file
    
    Some dumb git servers might reference a no longer existing pack file
    while it is possible to fully load a repository without it.
    
    So remove bogus pack file from the global packs list when encountering
    such edge case and try to continue the loading anyway.
    
    Related to T3618

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/141/ for more details.

Harbormaster completed remote builds in B24235: Diff 23322.Oct 5 2021, 4:16 PM

anlambert requested review of this revision.Oct 5 2021, 4:16 PM

ardumont accepted this revision.Oct 5 2021, 5:41 PM

This revision is now accepted and ready to land.Oct 5 2021, 5:41 PM

Closed by commit rDLDGd3d60421423a: dumb: Handle missing or corrupted pack file (authored by anlambert). · Explain WhyOct 5 2021, 5:58 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDGd3d60421423a: dumb: Handle missing or corrupted pack file.