Page MenuHomeSoftware Heritage

dumb: Handle missing or corrupted pack file
ClosedPublic

Authored by anlambert on Tue, Oct 5, 4:14 PM.

Details

Summary

Some dumb git servers might reference a no longer existing pack file
while it is possible to fully load a repository without it.

See for instance https://git.zap.org.au/git/console-fonts-utils.git/objects/info/packs
and https://git.zap.org.au/git/console-fonts-utils.git/objects/pack/.

So remove bogus pack file from the global packs list when encountering
such edge case and try to continue the loading anyway.

Related to T3618

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6416 (id=23322)

Rebasing onto 6b21441da6...

Current branch diff-target is up to date.
Changes applied before test
commit d3d60421423a981c82d214a184a59e23d4500532
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 5 16:07:58 2021 +0200

    dumb: Handle missing or corrupted pack file
    
    Some dumb git servers might reference a no longer existing pack file
    while it is possible to fully load a repository without it.
    
    So remove bogus pack file from the global packs list when encountering
    such edge case and try to continue the loading anyway.
    
    Related to T3618

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/141/ for more details.

This revision is now accepted and ready to land.Tue, Oct 5, 5:41 PM