Page MenuHomeSoftware Heritage

browse/snapshot_context: Fix empty snapshot browsing for staff users
ClosedPublic

Authored by anlambert on Tue, Oct 5, 2:58 PM.

Details

Summary

The generation of raw extrinsic metdata links only available for staff users
at the moment was not covered by tests and some bugs slip through.

That commit fixes those errors and improve related tests implementation.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6412 (id=23316)

Rebasing onto f2765a820a...

Current branch diff-target is up to date.
Changes applied before test
commit 8da34953ff61367d86ebee8f3c0ba4185a895ee9
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 5 13:48:50 2021 +0200

    browse/snapshot_context: Fix empty snapshot browsing for staff users
    
    The generation of raw extrinsic metdata links only available for staff users
    at the moment was not covered by tests and some bugs slip through.
    
    That commit fixes those errors and improve related tests implementation.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1137/ for more details.

This revision is now accepted and ready to land.Tue, Oct 5, 4:44 PM

Build is green

Patch application report for D6412 (id=23328)

Rebasing onto 84e550f6bf...

Current branch diff-target is up to date.
Changes applied before test
commit c8c0ac1eab92e54d514baa55e6a9ba27e13accae
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 5 13:48:50 2021 +0200

    browse/snapshot_context: Fix empty snapshot browsing for staff users
    
    The generation of raw extrinsic metdata links only available for staff users
    at the moment was not covered by tests and some bugs slip through.
    
    That commit fixes those errors and improve related tests implementation.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1141/ for more details.