Page MenuHomeSoftware Heritage
Differential D6411

tests: Wrap users creation in pytest fixtures
ClosedPublic
Actions

Authored by anlambert on Oct 5 2021, 2:24 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPSf2765a820add: tests: Wrap users creation in pytest fixtures
Summary

This improves tests readability while removing code duplication.

Diff Detail

Repository
rDWAPPS Web applications
Branch
users-fixtures
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24225
Build 37808: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 37807: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 5 2021, 2:24 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2021, 2:24 PM
swh-public-ci added a comment.Oct 5 2021, 2:38 PM

Build is green

Patch application report for D6411 (id=23312)

Rebasing onto 333ca8259c...

Current branch diff-target is up to date.
Changes applied before test
commit f2765a820add518ac926f50b950a7d392847fc82
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 5 14:16:37 2021 +0200

    tests: Wrap users creation in pytest fixtures

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1136/ for more details.

Harbormaster completed remote builds in B24225: Diff 23312.Oct 5 2021, 2:38 PM
anlambert requested review of this revision.Oct 5 2021, 2:38 PM
vlorentz accepted this revision.Oct 5 2021, 2:56 PM
vlorentz added a subscriber: vlorentz.

nice!

This revision is now accepted and ready to land.Oct 5 2021, 2:56 PM
Closed by commit rDWAPPSf2765a820add: tests: Wrap users creation in pytest fixtures (authored by anlambert). · Explain WhyOct 5 2021, 2:57 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSf2765a820add: tests: Wrap users creation in pytest fixtures.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
tests/
admin/
38 lines100%
Loading...
api/
26 lines100%
Loading...
views/
14 lines100%
Loading...
16 lines93%
Loading...

Diff 23312

View Options

swh/web/tests/admin/test_origin_save.py

Loading...
View Options

swh/web/tests/api/test_throttling.py

Loading...
View Options

swh/web/tests/api/views/test_origin_save.py

Loading...
View Options

swh/web/tests/conftest.py

Loading...
About · Developer information · Legal