Differential D6403

docker: use a dedicated container for the cron-like job of swh-web
ClosedPublic
Actions

Authored by douardda on Oct 4 2021, 5:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDENVaf0a2af3e7c8: docker: use a dedicated container for the cron-like job of swh-web

Summary

makes it easier to read the logs: just use:

swh-compose logs -f swh-web-cron

Depends on D6402

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 4 2021, 5:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 4 2021, 5:33 PM

douardda requested review of this revision.Oct 4 2021, 5:33 PM

Harbormaster completed remote builds in B24197: Diff 23280.Oct 4 2021, 5:33 PM

Nice! Fine with the current implem as it's the same as before in a dedicated container so better.

As @vsellier suggested can't we trap the signal, i've proposed a patch.

docker/services/swh-web/entrypoint.sh
25–31	Let's trap sigterm.

ardumont accepted this revision as: ardumont.Oct 4 2021, 5:44 PM

This revision is now accepted and ready to land.Oct 4 2021, 5:44 PM

ardumont accepted this revision.Oct 4 2021, 5:44 PM

@anlambert might be interested as well ;)

improve entrypoint script to properly handle a SIGTERM

and make docker-compose restart not wait for (up to) 15s

Harbormaster completed remote builds in B24204: Diff 23287.Oct 5 2021, 9:59 AM

indent...

Harbormaster completed remote builds in B24205: Diff 23288.Oct 5 2021, 10:01 AM

Closed by commit rDENVaf0a2af3e7c8: docker: use a dedicated container for the cron-like job of swh-web (authored by douardda). · Explain WhyOct 5 2021, 10:56 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDENVaf0a2af3e7c8: docker: use a dedicated container for the cron-like job of swh-web.

Revision Contents
Changeset List

Path

Size

docker/

docker-compose.yml

19 lines

services/

swh-web/

entrypoint.sh

21 lines

Diff 23290

View Options

docker/docker-compose.yml