Differential D6390

search: Add query language support for staff users
ClosedPublic
Actions

Authored by anlambert on Oct 1 2021, 3:02 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2254: textual search language for the Web UI

Commits

rDWAPPSd7ed7cae590d: search: Add query language support for staff users

Summary

When logged in as a staff user, a new checkbox will be displayed
enabling to search origins with the swh-search query language.

Remove not needed configuration entry.

Open query language documentation in a new browser tab.

Related to T2254

Diff Detail

Repository

rDWAPPS Web applications

Branch

search-add-ql-support-for-staff

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24157
Build 37702: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37701: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 1 2021, 3:02 PM

anlambert edited the summary of this revision. (Show Details)Oct 1 2021, 3:03 PM

anlambert added a task: T2254: textual search language for the Web UI.

Build is green

Patch application report for D6390 (id=23239)

Rebasing onto a41f090641...

First, rewinding head to replay your work on top of it...
Applying: search: Add query language support for staff users

Changes applied before test

commit ff8767624710a6ea04d932af3b5d6aeaa9096db2
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 1 14:54:24 2021 +0200

    search: Add query language support for staff users
    
    When logged in as a staff user, a new checkbox will be displayed
    enabling to search origins with the swh-search query language.
    
    Remove not needed configuration entry.
    
    Open query language documentation in a new browser tab.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1133/ for more details.

Harbormaster completed remote builds in B24156: Diff 23239.Oct 1 2021, 3:18 PM

anlambert requested review of this revision.Oct 1 2021, 3:18 PM

Oh, I forgot we already had the code for this. Thanks :)

This revision is now accepted and ready to land.Oct 1 2021, 3:27 PM

In D6390#165819, @vlorentz wrote:

Oh, I forgot we already had the code for this. Thanks :)

I did some testing and it seems to work properly, apart the language parsing errors that are not reported in the UI.
Also a some search features will not return a lot of results (like language or license) as those indexers are not active
in production since a while.

Nevertheless, it enables to start testing and using that feature.

Rebase

Build is green

Patch application report for D6390 (id=23240)

Rebasing onto a41f090641...

Current branch diff-target is up to date.

Changes applied before test

commit d7ed7cae590d262bb41ad8e77c969e9571c343f7
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 1 14:54:24 2021 +0200

    search: Add query language support for staff users
    
    When logged in as a staff user, a new checkbox will be displayed
    enabling to search origins with the swh-search query language.
    
    Remove not needed configuration entry.
    
    Open query language documentation in a new browser tab.
    
    Related to T2254

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1134/ for more details.

Harbormaster completed remote builds in B24157: Diff 23240.Oct 1 2021, 3:51 PM

Closed by commit rDWAPPSd7ed7cae590d: search: Add query language support for staff users (authored by anlambert). · Explain WhyOct 1 2021, 3:57 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSd7ed7cae590d: search: Add query language support for staff users.

vlorentz mentioned this in T3910: Add an option to enable the swh-search QL for some users.Feb 10 2022, 6:14 PM