Page MenuHomeSoftware Heritage

mercurial: Drop legacy loader
ClosedPublic

Authored by ardumont on Sep 27 2021, 7:03 PM.

Details

Summary

Keep only the new mercurial loader.

Related to T3612

Test Plan

tox (and check the coverage is still ok)

Diff Detail

Repository
rDLDHG Mercurial loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24032
Build 37496: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 37495: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6360 (id=23106)

Rebasing onto 395ea80518...

Current branch diff-target is up to date.
Changes applied before test
commit 293398d8136d767f02e5e99400a1f36c2b5c0b69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 27 19:00:44 2021 +0200

    mercurial: Drop dead code
    
    Keep only the new mercurial loader and make it the official one.
    
    Related to T3612

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/313/ for more details.

I'll try to make multiple commits to drop progressively stuff so renames appear.

It current does not for some reasons:

15 files changed, 1157 insertions(+), 3191 deletions(-)
README.md                                          |   10 +-
conftest.py                                        |    3 +-
setup.py                                           |    3 +-
swh/loader/mercurial/__init__.py                   |   16 +-
swh/loader/mercurial/bundle20_reader.py            |  621 -----------
swh/loader/mercurial/chunked_reader.py             |  105 --
swh/loader/mercurial/cli.py                        |   66 --
swh/loader/mercurial/from_disk.py                  |  815 --------------
swh/loader/mercurial/loader.py                     | 1142 +++++++++++---------
swh/loader/mercurial/tasks.py                      |   10 +-
swh/loader/mercurial/tasks_from_disk.py            |   43 -
swh/loader/mercurial/tests/test_from_disk.py       |  738 -------------
swh/loader/mercurial/tests/test_loader.py          |  721 ++++++++----
swh/loader/mercurial/tests/test_tasks.py           |    8 +-
swh/loader/mercurial/tests/test_tasks_from_disk.py |   47 -

Build is green

Patch application report for D6360 (id=23115)

Rebasing onto 395ea80518...

Current branch diff-target is up to date.
Changes applied before test
commit c46acc30ec3dfa69a95a4ecdc14b4ebdf2b62bdd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 28 10:46:37 2021 +0200

    mercurial: Drop dead code
    
    Keep only the new mercurial loader
    
    Related to T3612

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/315/ for more details.

vlorentz added a subscriber: vlorentz.

s/dead code/the legacy loader/ in commit/diff title

This revision is now accepted and ready to land.Sep 28 2021, 12:58 PM
ardumont retitled this revision from mercurial: Drop dead code to mercurial: Drop legacy loader.Sep 28 2021, 1:30 PM

Build is green

Patch application report for D6360 (id=23120)

Rebasing onto 395ea80518...

Current branch diff-target is up to date.
Changes applied before test
commit 37382ae61dc70380d18b63cb21686a6070b66ad5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 28 10:46:37 2021 +0200

    mercurial: Drop legacy loader
    
    Keep only the latest mercurial loader. In another commit, that loader will get renamed
    appropriately.
    
    Related to T3612

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/318/ for more details.

This revision was automatically updated to reflect the committed changes.