postgresql: Fix regression introduced in previous commit
ClosedPublic
Actions

Authored by anlambert on Sep 21 2021, 12:28 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO59e63db65c51: postgresql: Fix regression introduced in previous commit

Summary

Methods snapshot_get and snapshot_get_branches should return
None if the snapshot does not exist in the archive.

Add missing tests to cover that case.

Spotted thanks to swh-environment Jenkins job.

Diff Detail

Repository

rDSTO Storage manager

Branch

snapshot-get-regression-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23861
Build 37211: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37210: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 21 2021, 12:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 21 2021, 12:28 PM

Build is green

Patch application report for D6315 (id=22932)

Rebasing onto 9465054ef0...

Current branch diff-target is up to date.

Changes applied before test

commit 59e63db65c51e77c20dc97cc12af86e89fa22ab8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 21 12:25:25 2021 +0200

    postgresql: Fix regression introduced in previous commit
    
    Methods snapshot_get and snapshot_get_branches should return
    None if the snapshot does not exist in the archive.
    
    Add missing tests to cover that case.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1420/ for more details.

Harbormaster completed remote builds in B23861: Diff 22932.Sep 21 2021, 12:36 PM

anlambert requested review of this revision.Sep 21 2021, 12:36 PM

ardumont accepted this revision.Sep 21 2021, 1:11 PM

This revision is now accepted and ready to land.Sep 21 2021, 1:11 PM

Closed by commit rDSTO59e63db65c51: postgresql: Fix regression introduced in previous commit (authored by anlambert). · Explain WhySep 21 2021, 1:15 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSTO59e63db65c51: postgresql: Fix regression introduced in previous commit.