Differential D6309

common/models: Add note text field to SaveOriginRequest model
ClosedPublic
Actions

Authored by anlambert on Sep 20 2021, 4:00 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3256: Propose reason for rejecting a save code now

Commits

rDWAPPS86601bceb57b: common/models: Add note text field to SaveOriginRequest model

Summary

It will enable to store a swh-web admin redacted note related to
the save request, for instance the reason of rejection or explain
why a submitted save request failed.

Related to T3256

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-save-model-add-note-field

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24236
Build 37828: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 37827: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 20 2021, 4:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 20 2021, 4:00 PM

Build is green

Patch application report for D6309 (id=22899)

Rebasing onto 3a5f6087f1...

Current branch diff-target is up to date.

Changes applied before test

commit a2a4b954c1ce3db3a2089ac125f1356693f48348
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 16 11:44:50 2021 +0200

    common/models: Add note text field to SaveOriginRequest model
    
    It will enable to store a swh-web admin redacted note related to
    the save request, for instance the reason of rejection or explain
    why a submitted save request failed.
    
    Related to T3256

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1108/ for more details.

Harbormaster completed remote builds in B23825: Diff 22899.Sep 20 2021, 4:15 PM

anlambert requested review of this revision.Sep 20 2021, 4:15 PM

ardumont accepted this revision.Sep 20 2021, 4:21 PM

This revision is now accepted and ready to land.Sep 20 2021, 4:21 PM

Add missing doc about new note field in apidoc for /origin/save/

anlambert added a child revision: D6311: admin/origin_save: Parse optional note from rejection POST request body.Sep 20 2021, 5:48 PM

Build is green

Patch application report for D6309 (id=22901)

Rebasing onto 6700905387...

Current branch diff-target is up to date.

Changes applied before test

commit 7876a42ec4abfb026fd1497827642ab7343b9691
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 16 11:44:50 2021 +0200

    common/models: Add note text field to SaveOriginRequest model
    
    It will enable to store a swh-web admin redacted note related to
    the save request, for instance the reason of rejection or explain
    why a submitted save request failed.
    
    Related to T3256

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1109/ for more details.

Harbormaster completed remote builds in B23829: Diff 22901.Sep 20 2021, 5:59 PM

Rebase

Build is green

Patch application report for D6309 (id=23323)

Rebasing onto f2765a820a...

Current branch diff-target is up to date.

Changes applied before test

commit 86601bceb57bc0f783b9fe27180fcdb691f926bb
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 16 11:44:50 2021 +0200

    common/models: Add note text field to SaveOriginRequest model
    
    It will enable to store a swh-web admin redacted note related to
    the save request, for instance the reason of rejection or explain
    why a submitted save request failed.
    
    Related to T3256

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1138/ for more details.

Harbormaster completed remote builds in B24236: Diff 23323.Oct 5 2021, 4:48 PM

Closed by commit rDWAPPS86601bceb57b: common/models: Add note text field to SaveOriginRequest model (authored by anlambert). · Explain WhyOct 5 2021, 5:02 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS86601bceb57b: common/models: Add note text field to SaveOriginRequest model.