Page MenuHomeSoftware Heritage

Add a documentation page to list the services urls
ClosedPublic

Authored by vsellier on Sep 20 2021, 3:57 PM.

Diff Detail

Repository
rDDOC Development documentation
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23824
Build 37148: arc lint + arc unit

Event Timeline

ok, nice start.
Do you reference only the staging part?

docs/infrastructure/service-urls.rst
28

typo ^

Do you reference only the staging part?

Nope the diff is a draft to validate the format.
Production urls are in progress, (will be in the section line 84)

I put the staging urls first as it would be better to use them instead of the production ones.

docs/infrastructure/service-urls.rst
28

lol thanks. it's fixed

  • fix a couple of staging urls
  • add the production urls

complete other tools section

vsellier retitled this revision from WIP - add a documentation page to list the services urls to Add a documentation page to list the services urls.Sep 21 2021, 7:52 AM
vsellier edited the summary of this revision. (Show Details)
olasd added inline comments.
docs/infrastructure/service-urls.rst
67

RabbitMQ

vsellier edited the summary of this revision. (Show Details)

RabbitMq GUI -> RabbitMQ

vlorentz added inline comments.
docs/infrastructure/service-urls.rst
61–62

can we call them "RPC servers" instead? "backend" isn't very specific

docs/infrastructure/service-urls.rst
61–62

The RPC servers are listed in the previous section, in this one, it's more something like "databases".
I'm not really convinced too by "backend" but I have no better idea for now...

douardda added inline comments.
docs/infrastructure/service-urls.rst
25

nitpick: is there reason for keeping the trailing / on this one only?

60

Not read the whole doc, so maybe it's not a valid remqrk, but are "private" and "VPN" defined somewhere?

docs/infrastructure/service-urls.rst
25

no reason, It's the remaining probably, of a copy/paste I will clean that thanks

60

Nope good catch

  • Remove useless ending '/'
  • define VPN / private meanings

LGTM (not checked everything is accurate nor there are obvious missing services, but it's a huge improvement as is, thx)

This revision is now accepted and ready to land.Sep 22 2021, 11:41 AM