Page MenuHomeSoftware Heritage

Add the whole traceback in error messages.
ClosedPublic

Authored by vlorentz on Tue, Sep 14, 5:56 PM.

Details

Summary

No change in swh-web will only show the first line (D6259);
but this will include the detailed error in notification emails.

Resolves T3566

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6261 (id=22664)

Could not rebase; Attempt merge onto e141c56d70...

Updating e141c56..4cf7cf2
Fast-forward
 swh/vault/api/server.py   | 9 +--------
 swh/vault/backend.py      | 2 +-
 swh/vault/cookers/base.py | 5 ++++-
 3 files changed, 6 insertions(+), 10 deletions(-)
Changes applied before test
commit 4cf7cf269c65f78f4a677e6a16d80834146bd86d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 14 17:55:57 2021 +0200

    Add the whole traceback in error messages.
    
    No change in swh-web will only show the first line;
    but this will include the detailed error in notification emails.

commit 523f915839359cd93ca7eeacec2fede1542140ee
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 14 17:25:20 2021 +0200

    Add support for custom SMTP configuration
    
    Useful in docker to use mailhog instead of actually sending emails

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/179/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/179/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Sep 14, 5:59 PM
Harbormaster failed remote builds in B23599: Diff 22664!

Build is green

Patch application report for D6261 (id=22685)

Rebasing onto e141c56d70...

Current branch diff-target is up to date.
Changes applied before test
commit 3681a72c561d4c97e89a1d4e283dbd877f6f275d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 14 17:55:57 2021 +0200

    Add the whole traceback in error messages.
    
    No change in swh-web will only show the first line;
    but this will include the detailed error in notification emails.

commit 523f915839359cd93ca7eeacec2fede1542140ee
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 14 17:25:20 2021 +0200

    Add support for custom SMTP configuration
    
    Useful in docker to use mailhog instead of actually sending emails

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/180/ for more details.

ardumont added a subscriber: ardumont.

lgtm

Careful on the range of commits, i see duplicated stuff from the other diff about smtp setup (the virtual vcfg configuration part).

This revision is now accepted and ready to land.Wed, Sep 15, 1:57 PM

Build is green

Patch application report for D6261 (id=22689)

Could not rebase; Attempt merge onto e141c56d70...

Updating e141c56..3681a72
Fast-forward
 swh/vault/api/server.py              |  9 +--------
 swh/vault/backend.py                 |  2 +-
 swh/vault/cookers/base.py            |  5 ++++-
 swh/vault/tests/test_cookers_base.py | 14 ++++++++++++--
 4 files changed, 18 insertions(+), 12 deletions(-)
Changes applied before test
commit 3681a72c561d4c97e89a1d4e283dbd877f6f275d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 14 17:55:57 2021 +0200

    Add the whole traceback in error messages.
    
    No change in swh-web will only show the first line;
    but this will include the detailed error in notification emails.

commit 523f915839359cd93ca7eeacec2fede1542140ee
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 14 17:25:20 2021 +0200

    Add support for custom SMTP configuration
    
    Useful in docker to use mailhog instead of actually sending emails

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/181/ for more details.