Page MenuHomeSoftware Heritage

Change relation methods in `ProvenanceStorageInterface` to take/return denormalized data
ClosedPublic

Authored by aeviso on Mon, Sep 13, 10:41 AM.

Diff Detail

Repository
rDPROV Provenance database
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6243 (id=22593)

Could not rebase; Attempt merge onto 4c2b0907a9...

Updating 4c2b090..bfb67b1
Fast-forward
 swh/provenance/interface.py                        |  78 +--
 swh/provenance/mongo/backend.py                    | 388 +++++++--------
 swh/provenance/postgresql/provenance.py            | 117 +++--
 swh/provenance/provenance.py                       | 164 ++++---
 swh/provenance/sql/40-funcs.sql                    |  10 -
 swh/provenance/tests/test_origin_revision_layer.py |  14 +-
 swh/provenance/tests/test_provenance_storage.py    | 531 +++++++++++++--------
 .../tests/test_revision_content_layer.py           |  23 +-
 8 files changed, 723 insertions(+), 602 deletions(-)
Changes applied before test
commit bfb67b1b3e4ba4b11b87d5ddd6c9e8174b129101
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Sep 13 10:36:18 2021 +0200

    Change relation methods in `ProvenanceStorageInterface` to take/return denormalized data

commit 03d156bcb7fa12b544ec385bc50cad57f426a661
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Sep 9 16:40:33 2021 +0200

    Rework `ProvenanceStorageInterface` to have a single add method per entity
    
    All entities now have a single `<entity>_add` method in the interface, with optional
    associated date if applicable. A new `location_add` is also added to the interface.
    Extend all backend implementations to support the new methods. Add pre-condition to
    `relation_add` (relying on the new methods) which simplifies its different implementations.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/331/ for more details.

Build is green

Patch application report for D6243 (id=22594)

Could not rebase; Attempt merge onto 4c2b0907a9...

Updating 4c2b090..a83c4ac
Fast-forward
 swh/provenance/interface.py                        |  78 +--
 swh/provenance/mongo/backend.py                    | 387 +++++++--------
 swh/provenance/postgresql/provenance.py            | 117 +++--
 swh/provenance/provenance.py                       | 164 ++++---
 swh/provenance/sql/40-funcs.sql                    |  10 -
 swh/provenance/tests/test_origin_revision_layer.py |  14 +-
 swh/provenance/tests/test_provenance_storage.py    | 531 +++++++++++++--------
 .../tests/test_revision_content_layer.py           |  23 +-
 8 files changed, 722 insertions(+), 602 deletions(-)
Changes applied before test
commit a83c4acc63c9a5e702c1fde178ef35ccf8708747
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Sep 13 10:36:18 2021 +0200

    Change relation methods in `ProvenanceStorageInterface` to take/return denormalized data

commit 03d156bcb7fa12b544ec385bc50cad57f426a661
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Sep 9 16:40:33 2021 +0200

    Rework `ProvenanceStorageInterface` to have a single add method per entity
    
    All entities now have a single `<entity>_add` method in the interface, with optional
    associated date if applicable. A new `location_add` is also added to the interface.
    Extend all backend implementations to support the new methods. Add pre-condition to
    `relation_add` (relying on the new methods) which simplifies its different implementations.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/332/ for more details.

This revision is now accepted and ready to land.Mon, Sep 13, 1:06 PM

Build is green

Patch application report for D6243 (id=22598)

Could not rebase; Attempt merge onto 4c2b0907a9...

Updating 4c2b090..2e997f3
Fast-forward
 swh/provenance/interface.py                        |  86 ++--
 swh/provenance/mongo/backend.py                    | 400 +++++++--------
 swh/provenance/postgresql/provenance.py            | 125 ++---
 swh/provenance/provenance.py                       | 162 +++---
 swh/provenance/sql/40-funcs.sql                    |  10 -
 swh/provenance/tests/test_origin_revision_layer.py |  14 +-
 swh/provenance/tests/test_provenance_storage.py    | 541 +++++++++++++--------
 .../tests/test_revision_content_layer.py           |  23 +-
 8 files changed, 761 insertions(+), 600 deletions(-)
Changes applied before test
commit 2e997f31039dc9a4bbfd7fb5efa982329165810f
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Sep 13 10:36:18 2021 +0200

    Change relation methods in `ProvenanceStorageInterface` to take/return denormalized data

commit 657226a87bbe211e9e963a701a960aff58636e08
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Sep 9 16:40:33 2021 +0200

    Rework `ProvenanceStorageInterface` to have a single add method per entity
    
    All entities now have a single `<entity>_add` method in the interface, with optional
    associated date if applicable. A new `location_add` is also added to the interface.
    Extend all backend implementations to support the new methods. Add pre-condition to
    `relation_add` (relying on the new methods) which simplifies its different implementations.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/334/ for more details.