Differential D6222

api/vault: Re-add obj_type and obj_id to legacy API endpoints
ClosedPublic
Actions

Authored by vlorentz on Sep 9 2021, 12:03 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPSedb6bc332ac5: api/vault: Re-add obj_type and obj_id to legacy API endpoints

Summary

This broke Guix's client implementation:
https://lists.gnu.org/archive/html/guix-devel/2021-09/msg00115.html

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23467
Build 36616: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 36615: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 9 2021, 12:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 9 2021, 12:03 PM

Build is green

Patch application report for D6222 (id=22520)

Rebasing onto 25654a2764...

Current branch diff-target is up to date.

Changes applied before test

commit edb6bc332ac536799aa0ef88361ad915ce09927e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 9 12:03:08 2021 +0200

    api/vault: Re-add obj_type and obj_id to legacy API endpoints
    
    This broke Guix's client implementation:
    https://lists.gnu.org/archive/html/guix-devel/2021-09/msg00115.html

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1100/ for more details.

Harbormaster completed remote builds in B23467: Diff 22520.Sep 9 2021, 12:19 PM

vlorentz requested review of this revision.Sep 9 2021, 12:19 PM

anlambert accepted this revision.Sep 9 2021, 12:25 PM

This revision is now accepted and ready to land.Sep 9 2021, 12:25 PM

Closed by commit rDWAPPSedb6bc332ac5: api/vault: Re-add obj_type and obj_id to legacy API endpoints (authored by vlorentz). · Explain WhySep 9 2021, 1:14 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPSedb6bc332ac5: api/vault: Re-add obj_type and obj_id to legacy API endpoints.