Page MenuHomeSoftware Heritage

Add 'swh.vault.git_bare.ui' use role, to display the 'git bare' button on the UI
ClosedPublic

Authored by vlorentz on Sep 8 2021, 2:55 PM.

Details

Summary

It's always allowed with the API; but still restricted on the UI for now,
while we make sure that are no major issues.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23436
Build 36571: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 36570: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6212 (id=22484)

Rebasing onto b5ed695540...

First, rewinding head to replay your work on top of it...
Applying: Add 'swh.vault.git_bare.ui' use role, to display the 'git bare' button on the UI
Changes applied before test
commit e3d38f45e43b045ca100cf436fc2f8fa2315cb33
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Sep 8 14:55:35 2021 +0200

    Add 'swh.vault.git_bare.ui' use role, to display the 'git bare' button on the UI
    
    It's always allowed with the API; but still restricted on the UI for now,
    while we make sure that are no major issues.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1091/ for more details.

anlambert added a subscriber: anlambert.

Looks good to me.

You should add the new swh-web client role in docker keycloak but also in production keycloak.

This revision is now accepted and ready to land.Sep 8 2021, 3:18 PM

Build is green

Patch application report for D6212 (id=22486)

Rebasing onto 95440eca99...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1093-D6212.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1093/ for more details.