Details

Reviewers

moranegg

Maniphest Tasks

T1289: CodeMeta support in the metadata indexer

Commits

rDCIDX59dca309b166: Always output valid JSON-LD.

Summary

Our metadata extraction used to export a nested dict structure
loosely based on JSON-LD with schema.org/CodeMeta.

This diff makes it output proper JSON-LD data.

Note that because of some issues (eg.
https://github.com/codemeta/codemeta/issues/198 and the impossibility to
represent a software entity without a specific version), I removed
softwareRequirements and softwareSuggestions from the output

As a side-effect, it resolves T1289

PS: Morane, don't review this diff today, it can wait until tomorrow :)

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

output-jsonld

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1986
Build 2402: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 29 2018, 3:24 PM

Harbormaster completed remote builds in B1985: Diff 1897.Oct 29 2018, 3:24 PM

Better doc.

Harbormaster completed remote builds in B1986: Diff 1898.Oct 29 2018, 3:30 PM

Fix test.

Harbormaster completed remote builds in B1987: Diff 1899.Oct 29 2018, 3:36 PM

vlorentz edited the summary of this revision. (Show Details)Oct 29 2018, 4:16 PM

vlorentz added a task: T1289: CodeMeta support in the metadata indexer.

Simplify the normalization logic.

Harbormaster completed remote builds in B1989: Diff 1901.Oct 29 2018, 5:29 PM

zack added a subscriber: zack.Oct 29 2018, 5:34 PM

zack added inline comments.

swh/indexer/codemeta.py
24	This URI is here as a constant (good!) but its value is repeated in many places in the rest of this diff (bad :-)), violating DRY. It would be nice to remove other occurrences of this verbatim URI, e.g., using dictionary comprehension or string concatenation referencing this constant.