Page MenuHomeSoftware Heritage
Differential D6158

maven jar-loader: Initalise files.
AbandonedPublic
Actions

Authored by borisbaldassari on Aug 29 2021, 10:21 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T1724: Maven Central repository support
Summary

Implement a loader for maven jar source files.

Superseded after massive refactoring / renaming by D6396.

Test Plan

Tests fail for now, hence the diff request.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
T1724_maven_central_jar_loader
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23286
Build 36335: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 36334: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
162 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.jar.tests.test_jar::test_jar_visit_with_release_artifact_no_prior_visit
swh_storage = <swh.storage.proxies.retry.RetryingProxyStorage object at 0x7f2e0b4e6940> requests_mock = <requests_mock.mocker.Mocker object at 0x7f2e0b4e6b00> data_jar_1 = b'PK\x03\x04\n\x00\x00\x08\x08\x00\xba\\\xb7L\x00\x00\x00\x00\x02\x00\x00\x00\x00\x00\x00\x00\t\x00\x00\x00META-INF/\x...*\x00\x00al/aldi/sprova4j/models/Execution.javaPK\x05\x06\x00\x00\x00\x00#\x00#\x00\xe2\n\x00\x00\xf4,\x00\x00\x00\x00'
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_data
4 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_path
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_content_for_storage_too_long
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.core.tests.test_converters::test_prepare_contents
View Full Test Results (1 Failed · 156 Passed)

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
borisbaldassari updated this revision to Diff 22294.Aug 30 2021, 9:20 AM

Restart loader build after successful core build.

swh-public-ci added a comment.Aug 30 2021, 9:22 AM

Build has FAILED

Patch application report for D6158 (id=22294)

Rebasing onto 63a8a61cbc...

Current branch diff-target is up to date.
Changes applied before test
commit 3ad965971654d137d0c3058daf3fc370fc18318f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/510/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/510/console

Harbormaster failed remote builds in B23250: Diff 22294!Aug 30 2021, 9:22 AM
borisbaldassari updated this revision to Diff 22295.Aug 30 2021, 9:24 AM
  • maven jar-loader: add test and restart build.
swh-public-ci added a comment.Aug 30 2021, 9:26 AM

Build has FAILED

Patch application report for D6158 (id=22295)

Rebasing onto 63a8a61cbc...

Current branch diff-target is up to date.
Changes applied before test
commit ec9087810d30575e17899316bd5f87c20c39c021
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 3ad965971654d137d0c3058daf3fc370fc18318f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/511/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/511/console

Harbormaster failed remote builds in B23251: Diff 22295!Aug 30 2021, 9:26 AM
borisbaldassari updated this revision to Diff 22297.Aug 30 2021, 10:07 AM
  • maven jar-loader: fix tests.
swh-public-ci added a comment.Aug 30 2021, 10:09 AM

Build has FAILED

Patch application report for D6158 (id=22297)

Rebasing onto 63a8a61cbc...

Current branch diff-target is up to date.
Changes applied before test
commit 0391bfce1e0fb62e437648861de8d47531e6b1e5
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit ec9087810d30575e17899316bd5f87c20c39c021
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 3ad965971654d137d0c3058daf3fc370fc18318f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/512/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/512/console

Harbormaster failed remote builds in B23253: Diff 22297!Aug 30 2021, 10:09 AM
swh-public-ci added a comment.Aug 30 2021, 10:36 AM

Build has FAILED

Patch application report for D6158 (id=22297)

Rebasing onto 63a8a61cbc...

Current branch diff-target is up to date.
Changes applied before test
commit 0391bfce1e0fb62e437648861de8d47531e6b1e5
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit ec9087810d30575e17899316bd5f87c20c39c021
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 3ad965971654d137d0c3058daf3fc370fc18318f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/513/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/513/console

borisbaldassari updated this revision to Diff 22303.Aug 30 2021, 11:14 AM
  • maven jar-loader: fix, improve tests.
swh-public-ci added a comment.Aug 30 2021, 11:16 AM

Build has FAILED

Patch application report for D6158 (id=22303)

Rebasing onto 63a8a61cbc...

Current branch diff-target is up to date.
Changes applied before test
commit 570a6902616cb93f67df8d6362ec2fb1c8695c43
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 0391bfce1e0fb62e437648861de8d47531e6b1e5
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit ec9087810d30575e17899316bd5f87c20c39c021
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 3ad965971654d137d0c3058daf3fc370fc18318f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/514/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/514/console

Harbormaster failed remote builds in B23259: Diff 22303!Aug 30 2021, 11:16 AM
borisbaldassari updated this revision to Diff 22306.Aug 30 2021, 12:19 PM
  • maven jar-loader: fix timezone and tests, improve tests.
swh-public-ci added a comment.Aug 30 2021, 12:21 PM

Build has FAILED

Patch application report for D6158 (id=22306)

Rebasing onto 63a8a61cbc...

Current branch diff-target is up to date.
Changes applied before test
commit 3be490e991556677a5acb66b2d27f0f42784a62c
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 570a6902616cb93f67df8d6362ec2fb1c8695c43
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 0391bfce1e0fb62e437648861de8d47531e6b1e5
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit ec9087810d30575e17899316bd5f87c20c39c021
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 3ad965971654d137d0c3058daf3fc370fc18318f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/515/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/515/console

Harbormaster failed remote builds in B23262: Diff 22306!Aug 30 2021, 12:21 PM
borisbaldassari updated this revision to Diff 22322.Aug 31 2021, 9:02 AM
  • maven jar-loader: messing around with tests.
swh-public-ci added a comment.Aug 31 2021, 9:06 AM

Build has FAILED

Patch application report for D6158 (id=22322)

Rebasing onto 63a8a61cbc...

Current branch diff-target is up to date.
Changes applied before test
commit 45cb42c179ed44dfe23d57dd54fc53fc33245794
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 3be490e991556677a5acb66b2d27f0f42784a62c
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 570a6902616cb93f67df8d6362ec2fb1c8695c43
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 0391bfce1e0fb62e437648861de8d47531e6b1e5
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit ec9087810d30575e17899316bd5f87c20c39c021
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 3ad965971654d137d0c3058daf3fc370fc18318f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/516/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/516/console

Harbormaster failed remote builds in B23276: Diff 22322!Aug 31 2021, 9:06 AM
borisbaldassari updated this revision to Diff 22331.Aug 31 2021, 12:19 PM
  • maven jar-loader: fix tests.
  • maven jar-loader: fix tests.
swh-public-ci added a comment.Aug 31 2021, 12:21 PM

Build has FAILED

Patch application report for D6158 (id=22331)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Changes applied before test
commit 2e78598b6f1c9bb4cb3c3a6ea185a0031480d5f3
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 432f4cf1e87b2f4715165cbd1165d5594f97cf21
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit ab5fbaf637a653e968e507af3d26c3c0e935afa0
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit cb40e29ea4670cbe1cc8d777c05298b882978ece
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit a5e7090f97c63a8d14ed14e30ebaa89d1c503f97
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit d37914ecb0a5828413e3a3d7bcdee328357ecb31
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit 428cc9a93b1007e8f6f3e770fbacfff7eb8a6c13
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit a6a2b9ec8e373b3c508ce2c66ecdfcb9acff097f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/520/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/520/console

Harbormaster failed remote builds in B23285: Diff 22331!Aug 31 2021, 12:21 PM
borisbaldassari updated this revision to Diff 22332.Aug 31 2021, 12:30 PM
  • maven jar-loader: un-change loader.py (cleanup debug statements).
swh-public-ci added a comment.Aug 31 2021, 12:32 PM

Build has FAILED

Patch application report for D6158 (id=22332)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Changes applied before test
commit f59a0cc771414dd02bda34335e62321b1fa7a599
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit 47198b6a2a845e351128ed06d38538d292dc5f39
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 32a250606957ae27468969e7f8ee410726a50f2b
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit b0a18f001275fe5a354c02557bbb09f383bf265e
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 39a8fea05652af5617888dd8469f06f0fc6116e2
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit e4169b79c1ba77f1236f4e708f2ba9820474c404
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit f09427c60b82efb6dc08cf779f68c6ec5b3b6bd6
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit 24a7f10e855dee66e77b977b1197ee653aa8b206
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 603b24aca7f23df1b590a529bae16d7bed62e039
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/521/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/521/console

Harbormaster failed remote builds in B23286: Diff 22332!Aug 31 2021, 12:32 PM
borisbaldassari updated this revision to Diff 22345.Aug 31 2021, 10:08 PM
  • maven jar-loader: fix + add tests.
swh-public-ci added a comment.Aug 31 2021, 10:10 PM

Build has FAILED

Patch application report for D6158 (id=22345)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Changes applied before test
commit 0a2ab6713c51b2cd4df445b24df309367b0c78b4
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit 737d900f3516465fc5d2fd41dddf10b8c1f49976
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit 3c0baf6284cc35c0cf61339fea2b20c7c0d70608
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 023b37c933475024bc56376657a59dab5516eede
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit 7139f15f411e057d571e04592b0a98c775512b01
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 2f9ca1e5754ea3a5f68f3fb060ee2a7da29cd0f1
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 5887219177ba9cd832a0f577c7fb9309ab898700
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 79a2503ef23d52ef685216a0fe43af05507e2306
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit bd06422d6e3b9aa3a7b4bc7b54cfb1400c6f4b60
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 8f097714fa78a1098f327d1ca4f621d2a01cf3a9
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/522/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/522/console

Harbormaster failed remote builds in B23301: Diff 22345!Aug 31 2021, 10:10 PM
borisbaldassari added a comment.Sep 1 2021, 8:44 AM

Hey good people, this failing test [1] and the snapshot_id mentioned in the code actually work well on my local setup. How can it be that snapshot_id's are different on different hosts?
More specifically: snapshot_id on jenkins is 'ae8f76fe879ea040312182c02dae324a11252f83' and on my local setup is '677b0280cbe9e650c9dfa80fbb1ab7ebb1603c86'.

[1] 20:10:47  >       assert (
20:10:47              hash_to_bytes(actual_load_status["snapshot_id"])
20:10:47              == expected_snapshot_first_visit_id
20:10:47          )
20:10:47  E       AssertionError: assert b'\xae\x8fv\x...e2J\x11%/\x83' == b'g{\x02\x80\...xeb\xb1`<\x86'
20:10:47  E         At index 0 diff: b'\xae' != b'g'
vlorentz added a subscriber: vlorentz.Sep 1 2021, 11:59 AM

It means one of the members is different, but it's impossible to tell which.

Instead of only comparing ids, you should compare the whole snapshot.

(some unrelated comments below)

swh/loader/package/jar/loader.py
47–48

(not for gnu)

Are you sure versions can only have one package, and it will never change? I'd rather include $time either way. It should also include a way to identify the Maven instance this is from, or they could collide.

Are the gid, aid, and version guaranteed not to contain spaces? (if they do, they may collide too)

And you should change the EXTID type (eg. "maven-jar")

160

This will crash if p_info.time is a datetime

vlorentz requested changes to this revision.Sep 2 2021, 10:30 AM
This revision now requires changes to proceed.Sep 2 2021, 10:30 AM
borisbaldassari updated this revision to Diff 22391.Sep 3 2021, 2:39 PM
borisbaldassari marked an inline comment as done.
  • maven jar-loader: fix minor typos + tests.
swh-public-ci added a comment.Sep 3 2021, 2:41 PM

Build has FAILED

Patch application report for D6158 (id=22391)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Changes applied before test
commit c428ec12d41d20d4c9846af34bbbf3dda2927c9c
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit f6c7ccbf9621ef35341c771f15cc5231188e11d3
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit 5255c76e22c7b7ecd1e296f658b66ceeea294ebc
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit f8b1c3c6d7a53eb6088c4d431dfe740ca0dbdf2a
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit acfc07506ae5b55f9acb9bdb93464a32d7e37c1b
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit 49867dd510dfe1b6d09333a8444364db41c4c2a1
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 4f27eee79870754c6fec79366fe4821f281b3b15
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 7d47af1ec10844d887c4e1b1225ac0d26fcf9148
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 993d939f59536f67b193726e679854af9be21052
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit d11fa49822ed8b60c1aa22327c3193a24590c017
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit a7fed36c79bb61d7d20b07a77b8a4cc9754f194e
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/524/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/524/console

Harbormaster failed remote builds in B23345: Diff 22391!Sep 3 2021, 2:41 PM
borisbaldassari updated this revision to Diff 22392.Sep 3 2021, 2:43 PM
  • maven jar-loader: fix minor typos + tests.
swh-public-ci added a comment.Sep 3 2021, 2:45 PM

Build has FAILED

Patch application report for D6158 (id=22392)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix minor typos + tests.
Changes applied before test
commit cacb41c6fc0015094772ac7d5792b8ca0b2d21b8
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:43:07 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit 8286e81ebd8fd5de3e7d6911c8171ee7d972fd6d
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit 7af9f121e3dc7ea7d5a1a8ed0a1260326be9e4fd
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit 6367265b0a2057fcd036f468e17fb607aa85e572
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit 0ca49040d9759b2abb8edd497ac9af67e7e2aa36
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 619e2960ee79ec7e54835c54ce5dc4c5f079c1f6
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit 7f8ef8cf25da84cfe9e6fc0912ab71f3f44c95f0
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit bcaba482591904aacc2b230a2410b2a375215303
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 79bbeeeb38ae1c64836a35cb811112c49ccf089f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit d18a45502da31a78b32af134547aeaec274493d3
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit 7189e1afadd8df714c5676ab7a2052ea0347b860
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit d2d51f9d5dc4dfe251479cd470ec092dc43e480f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/525/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/525/console

Harbormaster failed remote builds in B23346: Diff 22392!Sep 3 2021, 2:45 PM
borisbaldassari updated this revision to Diff 22395.Sep 3 2021, 3:13 PM
  • maven jar-loader: fix tests.
swh-public-ci added a comment.Sep 3 2021, 3:16 PM

Build has FAILED

Patch application report for D6158 (id=22395)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix tests.
Changes applied before test
commit c0f6abb0d6869d821a9b1cb37e9c3321506051f9
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:13:32 2021 +0200

    maven jar-loader: fix tests.

commit 58365b395360297e6b396795b9967bc38a933543
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:43:07 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit 2b2a2535379df4897a50b1af9ded6adf9f29dd1c
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit 2910edbe5646df950e7035640cb4e9c57923090b
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit 8a10740b71ee06d03a47d4dda5a232c9356e14e9
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit 26f52625767493c2628f7c39aea53a1699ef33de
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit a085cefe5320ed9e2cbdc319f0936e0b4fb8a8e2
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit 05d4c24531b7ce0dd3dc8b7ce5159732c4edad81
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 25b5250f4be26a971da10241303c5bb79b72ddb8
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 6de0afb540b95a0709d8fd3e64c35fc10de7ff2a
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 788df29935d832a13b868b49dd5edfa7a1ec61a2
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit ed4a2b1399f279a76eef1d64e2f44ae807c8075b
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit e2c178aec544428ab494b13c7f42a66fa0d471f1
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/526/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/526/console

Harbormaster failed remote builds in B23349: Diff 22395!Sep 3 2021, 3:16 PM
borisbaldassari updated this revision to Diff 22396.Sep 3 2021, 3:32 PM
  • maven jar-loader: fix tests.
swh-public-ci added a comment.Sep 3 2021, 3:34 PM

Build has FAILED

Patch application report for D6158 (id=22396)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Changes applied before test
commit afdc33737e62f11f3a3d6dcb1af08b8e19d2688f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:31:41 2021 +0200

    maven jar-loader: fix tests.

commit 34cd052f9f40d75cdd313e4be9f5989d79c93b58
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:13:32 2021 +0200

    maven jar-loader: fix tests.

commit 814b43172bdceb5aea66620ce602bb07a199edf7
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:43:07 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit c234a652acd88dab2266c4d8af87f32f599271e1
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit e3771479cf577117f1ecc457cc49c6f6e0d9c658
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit 558c27a233c06cb2567bd39404ea045acb982b20
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit c6842cbd8fbad651486b6193ef753135f2b4c69f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 761c919d8f9f2f8973edc987d66b99caf417b03f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit 0688744044e666d9c6bcd4a6131f47a3b8d4e6ed
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 9482c3e5da38c75ec103ecd6c21b77653da1d3bb
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 69435930432098a2f64c5f0c2823307ece4a8c75
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 408aec5e0c25019b84e9f380c9d2e4c0362ceff8
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit 5304327c3c95ff18151b0afaa925017f297bfe73
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 71ce57cefb7fffca89e8774e223c7c6b1a354879
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/527/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/527/console

Harbormaster failed remote builds in B23350: Diff 22396!Sep 3 2021, 3:34 PM
borisbaldassari updated this revision to Diff 22401.Sep 3 2021, 3:45 PM
  • maven jar-loader: fix tests.
swh-public-ci added a comment.Sep 3 2021, 3:48 PM

Build has FAILED

Patch application report for D6158 (id=22401)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Changes applied before test
commit fedf0dca9c34da69de8b90760c82529ec7349713
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:45:20 2021 +0200

    maven jar-loader: fix tests.

commit f662ea6fd4a31352d6460ad233f328cb625bd1cb
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:31:41 2021 +0200

    maven jar-loader: fix tests.

commit 0f133edd530748c518c62a32a8f7c08dac06f772
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:13:32 2021 +0200

    maven jar-loader: fix tests.

commit 41a5c7e533391f90b401e8d15515383c745c2f0c
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:43:07 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit ca91666da47b65e7e80ce5d0283cafd9129de8ab
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit 8e20ee7b382788ed6e803380ff0f85f5ba0f09fe
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit 58ce6cafa1cc762a27f444c11cfcf9c0b2a9ef82
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit 26cb0cdd458f0cbc69ff51ee3958ddaf863b8ca5
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 506aa40001b721814456f4878ffc11e20b012730
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit 6449615e7c933a9e0634988dd4d5a076f459ab2c
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit d23b775feeab058c1fb5acb520f3da7945797208
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 91fd22f4e4cbf9c1d7e70cf203147940f8900657
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit d5470dc427b0c2b2bc3ccde6b95844707de2710d
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit 5154c7858190f394813053cacce567c6751fb93e
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 4724cdc00f0cc796948acca3d6a95eceb63b0a50
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/528/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/528/console

Harbormaster failed remote builds in B23355: Diff 22401!Sep 3 2021, 3:48 PM
borisbaldassari updated this revision to Diff 22403.Sep 3 2021, 4:00 PM
  • maven jar-loader: fix tests.
swh-public-ci added a comment.Sep 3 2021, 4:02 PM

Build has FAILED

Patch application report for D6158 (id=22403)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Changes applied before test
commit fe1c2d72682059dddb1d7287d9b4f2359d261310
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:59:52 2021 +0200

    maven jar-loader: fix tests.

commit 4ad45e7732495da051b807f14bff54d8aeafb1cb
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:45:20 2021 +0200

    maven jar-loader: fix tests.

commit ace5c9fad64aeefe6cae9557d583419473d493f3
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:31:41 2021 +0200

    maven jar-loader: fix tests.

commit cca0caa1df1e8ccd22375acfee611a22669a6ed3
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:13:32 2021 +0200

    maven jar-loader: fix tests.

commit e0c821c9ff2da3fb17037448df5919eae76ff973
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:43:07 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit bab611977813a31baa2fe0c5c1a6e6b19375140a
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit ea3617a3b749aaeedc15c702a63910f9b1112d5a
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit 75628665cfd126bbb8ab34129db3d1af705a6a53
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit afbcaf6138fca4e652da8fd24bdbb24d5f2ff6ca
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 7c399f3e28d5fc6a2c88d9f2e1c13c9e388bc1df
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit 0086bca45c0b9f43ce3f3bf762c84cb5b680937d
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 3ec5979ec6ed8f5c6367f062d9117d0e9d348124
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 7b3f00556d4b9f1bac647e5298d416ff6465ccb6
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 71b37c1900ea79d0eb6a0fba5c6d41b55a87f939
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit 78d62c65289d9760bf49fa7bfe2162bc8c0610ff
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 5627c9c1a2170bba3c6456fbf0ae58c5ea5ec1f4
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/529/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/529/console

Harbormaster failed remote builds in B23357: Diff 22403!Sep 3 2021, 4:02 PM
borisbaldassari updated this revision to Diff 22412.Sep 4 2021, 11:32 AM
  • maven jar-loader: fix tests.
swh-public-ci added a comment.Sep 4 2021, 11:34 AM

Build is green

Patch application report for D6158 (id=22412)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Changes applied before test
commit 088a29bc6e11b94aca364c67577a3d743f2578d6
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sat Sep 4 11:32:26 2021 +0200

    maven jar-loader: fix tests.

commit cfbacbf743d3d85ac80319e545c9627c4a47494d
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sat Sep 4 11:31:18 2021 +0200

    maven jar-loader: fix tests.

commit 4022f7cc5f69cad4a6cd281204ee75e6e1f0a624
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 17:26:18 2021 +0200

    maven jar-loader: fix tests.

commit 7915ff89fa6a565ad3a9eb54348c04e7ab0d59e0
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:59:52 2021 +0200

    maven jar-loader: fix tests.

commit c8b929245162ff0191fcae198cc2f8203db4fc28
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:45:20 2021 +0200

    maven jar-loader: fix tests.

commit 9020f2844e1144c8bd5208130636b09e58042cad
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:31:41 2021 +0200

    maven jar-loader: fix tests.

commit c7d104474b6e2739fc4df6f3fd419da1d73c55a8
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:13:32 2021 +0200

    maven jar-loader: fix tests.

commit 2a88dec40f35b3766f46dfde4dff5e7263d534d3
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:43:07 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit 7c62e5cc0f8c5ceefd19f346de31aece7b465d17
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit 35c2ea4d0934421d148b7d86c42d54883422dce4
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit d2888c02bcc39047d94e9d3558138077d3f7dc96
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit 5f309a45ed4cc7e85d4f8edd1aa79166955fd346
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit d71698be4a5a13df2eed0cbfd8187e89ac176e3f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit b4d9708c80f2b8270d021b34f1cf89030e4e3127
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 635dd29623f2ec7711fecec3d0c7545832e46404
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 66ab926ced0e5ffacabdf57106a0f86c6e64d700
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 20262473f7a95e15939bad0c096ab3744bd7f8d4
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit 25229e0343bac747317168b657ce548cdd54d96d
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 6c117997cef620e5969feb81f193c024ea14a843
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/532/ for more details.

Harbormaster completed remote builds in B23366: Diff 22412.Sep 4 2021, 11:34 AM
borisbaldassari added a comment.Sep 4 2021, 12:07 PM

Hiho good people,

Before any review happens, there is still a piece we need to discuss: extrinsic metadata.
The main interest of building a specific loader for jars (which basically are archives and could be eaten by the existing 'archive' loader) is to add some extra metadata to the artifacts.

The most obvious metadata would be group_id, artifact_id, and version (which are the three distinctive parameters of any maven jar), stored as strings. Is there anything else we would like to see there?

swh/loader/package/jar/loader.py
47–48

Good point for the gnu! Thanks.

Yes, a single jar has a unique set of coordinates (gid, aid, version) and this is part of the maven spec so I don't think that collisions could happen (or should be allowed).

I didn't include the time or url because artifacts can be hosted at several places, and they should still be the same. We don't want to re-archive an artifact (gid, aid, version) that is already ingested or present elsewhere, even if the url has changed. And "time" is the publication time on the server so it could change on a different server but would nevertheless be the same artifact.

And no, I've never seen an artifact with spaces inside the name. That should not happen.

160

Right. Fixed.

vlorentz added inline comments.Sep 6 2021, 3:25 PM
swh/loader/package/jar/loader.py
47–48

and they should still be the same

I does not look like we can be *sure* they are the same. And if they are not, we will miss some source code. It's better to load it twice than risk losing it. The result of the loader is deduplicated in the storage anyway.

Additionally, "$gid $aid $version" is specific to Maven (if I'm not mistaken), so it feels out of place for a generic JAR loader.

borisbaldassari updated this revision to Diff 22588.Sep 12 2021, 4:08 PM
  • maven jar-loader: add extrinsic metadata.
swh-public-ci added a comment.Sep 12 2021, 4:10 PM

Build is green

Patch application report for D6158 (id=22588)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: add extrinsic metadata.
Changes applied before test
commit e9fbc6fc60a1bd423051bd663038a126b9971722
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Sep 12 16:05:27 2021 +0200

    maven jar-loader: add extrinsic metadata.

commit 7249766da3f5b9727bc12f53a783f95d02a02b65
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sat Sep 4 11:32:26 2021 +0200

    maven jar-loader: fix tests.

commit ad5db02b3375253ea5ad62b27c49a0c15344bb67
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sat Sep 4 11:31:18 2021 +0200

    maven jar-loader: fix tests.

commit 31db1b7f4da69e5165738df4ed274b533181706c
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 17:26:18 2021 +0200

    maven jar-loader: fix tests.

commit dc99a70e68eb126c9d06c535205ca0bcec6dff40
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:59:52 2021 +0200

    maven jar-loader: fix tests.

commit 6060f52f960fb0cfa0b633d452aa1004660b55ae
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:45:20 2021 +0200

    maven jar-loader: fix tests.

commit 2a329a0880d7e3fb74be5c4322e8a4f4a13de19a
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:31:41 2021 +0200

    maven jar-loader: fix tests.

commit 9a96ae99ba148ec028aa250577d22ee19642b35a
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:13:32 2021 +0200

    maven jar-loader: fix tests.

commit af45fa30c8d0d4d5b92fd13f865781c36a2171ff
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:43:07 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit b23c1199024ff0aed21da906a738ceb65c3726c7
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit df6f0826126e215987a952c91ec7da5c58c3efea
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit bc41bcc5779a2a82c7773f403ecdbf5ec9ce4d20
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit 1f37cbcec486d2a6564f9837741b324539230b7b
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 97bf674b2484811537ebcb11d8a77be876bed684
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit de23fd71a03cde90c054ca479d001ebd9275e15f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit 1494cfc0328a72fc143bb457d3a1d126be789444
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 57dbc610125fbfdf399d419a83f5c2e60e70f3f9
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit 4668f77bfff7eb105c43f9b2b62592abbde99000
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit 0a617f29a425fc443c3bdf8f9583e677c28e02aa
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 9d6051e4364011c93f5f1f33c2a4b954f3fe412b
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/538/ for more details.

Harbormaster completed remote builds in B23523: Diff 22588.Sep 12 2021, 4:10 PM
borisbaldassari updated this revision to Diff 22591.Sep 12 2021, 7:17 PM
  • maven jar-loader: cleanup unnecessary comments.
swh-public-ci added a comment.Sep 12 2021, 7:19 PM

Build is green

Patch application report for D6158 (id=22591)

Rebasing onto 50b062adc7...

First, rewinding head to replay your work on top of it...
Applying: maven jar-loader: Initalise files.
Applying: maven jar-loader: add test and restart build.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: fix, improve tests.
Applying: maven jar-loader: messing around with tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: un-change loader.py (cleanup debug statements).
Applying: maven jar-loader: fix + add tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix minor typos + tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: fix tests.
Applying: maven jar-loader: add extrinsic metadata.
Applying: maven jar-loader: cleanup unnecessary comments.
Changes applied before test
commit dd12f2e2327d380d6d5016f2956c2692a75f47fe
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Sep 12 19:14:56 2021 +0200

    maven jar-loader: cleanup unnecessary comments.

commit 9ccfaddaceaf07b6c5b2b8ddcbdbbeaf756b1e32
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Sep 12 16:05:27 2021 +0200

    maven jar-loader: add extrinsic metadata.

commit 9f6cf58f87babdfe6711f5090148f2d25aad21e2
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sat Sep 4 11:32:26 2021 +0200

    maven jar-loader: fix tests.

commit bbf35b6f1447db4c9a1fc58d46e3870142c75ae7
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sat Sep 4 11:31:18 2021 +0200

    maven jar-loader: fix tests.

commit 19f98cd618cea5b3b97c7596ff055b915183a23f
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 17:26:18 2021 +0200

    maven jar-loader: fix tests.

commit 01b52be6b5b98347fd809e9c08b14f98b4543f16
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:59:52 2021 +0200

    maven jar-loader: fix tests.

commit 649dc0e04de8b4de5364d77056d6babc48e1a6e1
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:45:20 2021 +0200

    maven jar-loader: fix tests.

commit 37965891a7cdd4a0b0c50b8501a66a8dc7ab12c6
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:31:41 2021 +0200

    maven jar-loader: fix tests.

commit 6be89bb7b9a040adc5c73cda4d10623fcda16fc6
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 15:13:32 2021 +0200

    maven jar-loader: fix tests.

commit 270c47430ba1125c78373106e38cd7384a7b7eec
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:43:07 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit e832c0e565c6f4b0c2301e89b3155c3882bd70ed
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Fri Sep 3 14:38:25 2021 +0200

    maven jar-loader: fix minor typos + tests.

commit ff4129d610b30df8b0d1be2660b075459c881811
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 22:05:27 2021 +0200

    maven jar-loader: fix + add tests.

commit 9a13ed738c91daa0ecef155bc0551bb8bf6595a4
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:28:58 2021 +0200

    maven jar-loader: un-change loader.py (cleanup debug statements).

commit 08ec9a7c2eb1bdcf2376dd61301b3be4b51a95c3
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 12:18:22 2021 +0200

    maven jar-loader: fix tests.

commit 0f18b11628b363bf33771644aff3b699ab7086a0
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 11:36:28 2021 +0200

    maven jar-loader: fix tests.

commit db113a3784f6ef89fbf40477c7aa6773577f91d3
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Tue Aug 31 09:00:09 2021 +0200

    maven jar-loader: messing around with tests.

commit b188d8a83705e22c96a54b20dfc29f4fa127ce09
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 12:18:08 2021 +0200

    maven jar-loader: fix, improve tests.

commit 8f743410ed1366c762f8ad4bd3efc59038298709
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 11:12:52 2021 +0200

    maven jar-loader: fix, improve tests.

commit f636530b8ec50e117773eb74a900e24013545639
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 10:05:14 2021 +0200

    maven jar-loader: fix tests.

commit cebfd7cc09fc63f5f81042528ec13fff879f551d
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Mon Aug 30 09:23:52 2021 +0200

    maven jar-loader: add test and restart build.

commit 599c591080540026e7f353dbba95b38bd106acd2
Author: Boris Baldassari <boris@chrysalice.org>
Date:   Sun Aug 29 22:14:59 2021 +0200

    maven jar-loader: Initalise files.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/539/ for more details.

Harbormaster completed remote builds in B23526: Diff 22591.Sep 12 2021, 7:19 PM
borisbaldassari edited the summary of this revision. (Show Details)Oct 2 2021, 9:57 PM
ardumont mentioned this in D6395: lister: Add new maven lister.Oct 26 2021, 3:12 PM
ardumont added a subscriber: ardumont.Oct 26 2021, 4:27 PM

@borisbaldassari Same as for the listers, can you please close this (bottom of the page, "abandon" revision in the selection box)

Please add a comment "superseded by D6396" (i know it's in the description but heh might as well repeat the reason of the closing ;)

ardumont added a comment.Oct 26 2021, 4:27 PM

@borisbaldassari Same as for the listers, can you please close it (bottom of the page, "abandon" revision)

Please add a comment "superseded by D6396" (i know it's in the description but heh ;)

Thanks in advance.

ardumont mentioned this in D6396: Implement maven jar source files loader.Oct 26 2021, 4:29 PM
borisbaldassari abandoned this revision.Oct 27 2021, 8:20 AM

Superseded after massive refactoring / renaming by D6396.

swh/loader/package/jar/loader.py
47–48

Hum. I'm a bit lost here, and what you say has huge implications.

I does not look like we can be *sure* they are the same. And if they are not, we will miss some source code. It's better to load it twice than risk losing it. The result of the loader is deduplicated in the storage anyway.

I really can't imagine a situation where a source jar is republished with the same gid/aid/version and different content. This goes quite directly against the maven principle of unique coordinates, and if a security fix or a change is needed then one must republish the jar with an incremented version. The only extremely rare case I can think of is when there is an IP infringement, for it could threaten the hosting entity. Do you have any other situation in mind?

In other words, what information would you add or change to the extid? url, timestamp? From the maven perspective, the vast majority of artifacts have a single url, which is where they are officially published by their author. People can still mirror any artifacts on other repositories, but that would be quite rare. Adding the url in the extid would re-ingest them, which is ok but imho unnecessary since they'll be identical. Nobody wants to create a second artifact with the same coordinates, apart for local testing maybe.

Please bear in mind that I'm not arguing, I'm just trying to understand the requirements correctly.

Additionally, "$gid $aid $version" is specific to Maven (if I'm not mistaken), so it feels out of place for a generic JAR loader.

Maybe I should have used 'maven' rather than 'jar' for the loader name then. It was really intended for the maven lister and ecosystem, and the gid/aid/version parameters, as it is currently, are actually required. Making it a generic jar loader would imply to strip this information (both in the constructor and for the extrinsic metadata), but then it would be closer to the 'archive' loader. The main difference between the archive loader and the jar loader is the metadata.

It should be quite easy to add the jar extension to the archive loader, and I can take care of that. WDYT?

vlorentz added inline comments.Nov 17 2021, 11:28 AM
swh/loader/package/jar/loader.py
47–48

Sorry, I missed the notification.

I really can't imagine a situation where a source jar is republished with the same gid/aid/version and different content.

Even on https://repo1.maven.org/maven2/ alone, I found a couple of POMs with the same (gid, aid, version). I can look in my logs to give you an example later, if you want.

Additionally, I don't see any guarantee that (gid, aid, version) are unique across all repositories. For example, if Atlassian publishes an artifact with a given (gid, aid, version) in their own repository, what is stopping me from uploading a different one with the exact same triple in https://repo1.maven.org/maven2/ ?

People can still mirror any artifacts on other repositories, but that would be quite rare. Adding the url in the extid would re-ingest them, which is ok but imho unnecessary since they'll be identical. Nobody wants to create a second artifact with the same coordinates, apart for local testing maybe.

I don't think we can assume this. At scale, if people can do something stupid, you can be sure at least one person will do it. For example in PyPI we find a ton of packages will tarballs whose name does not match the package name, even if the tooling is supposed to prevent it.

In other words, what information would you add or change to the extid? url, timestamp?

At least the URL, yes. The timestamp would be great too, if possible.

Maybe I should have used 'maven' rather than 'jar' for the loader name then. It was really intended for the maven lister and ecosystem, and the gid/aid/version parameters, as it is currently, are actually required.

I see. Renaming would be nice, then.

borisbaldassari mentioned this in rDLDBASE89f5ccc7f5fc: loader: add new maven-jar loader.Dec 6 2021, 2:45 PM

Revision Contents
Changeset List

PathSize
1 line
swh/
loader/
package/
jar/
17 lines
180 lines
17 lines
tests/
data/
https_maven.org/
395 lines
50 lines

Diff 22332

View Options

setup.py

Loading...
View Options

swh/loader/package/jar/__init__.py

Loading...
View Options

swh/loader/package/jar/loader.py

Loading...
View Options

swh/loader/package/jar/tasks.py

Loading...
View Options

swh/loader/package/jar/tests/__init__.py

Loading...
View Options

swh/loader/package/jar/tests/data/https_maven.org/sprova4j-0.1.0-sources.jar

Loading...
View Options

swh/loader/package/jar/tests/data/https_maven.org/sprova4j-0.1.1-sources.jar

Loading...
View Options

swh/loader/package/jar/tests/test_jar.py

Loading...
View Options

swh/loader/package/jar/tests/test_tasks.py

Loading...
About · Developer information · Legal