When a content cannot be displayed (for instance due to a too large size),
remove script tag from template to prevent execution errors.
Closes T3454
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T3454: Displaying "large" PDF raise a Javascript error
- Commits
- rDWAPPSf15e17c406c0: templates/content-display: Remove script tag when no content to display
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23239 Build 36259: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 36258: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6155 (id=22283)
Rebasing onto 3a448d88c8...
Current branch diff-target is up to date.
Changes applied before test
commit b8c2933c97a35067be5b44230927cb00c6f3d290
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Fri Aug 27 16:14:13 2021 +0200
templates/content-display: Remove script tag when no content to display
When a content cannot be displayed (for instance due to a too large size),
remove script tag from template to prevent execution errors.
Closes T3454See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1040/ for more details.
Comment Actions
Build is green
Patch application report for D6155 (id=22301)
Rebasing onto 9f358af9a4...
Current branch diff-target is up to date.
Changes applied before test
commit f15e17c406c01972efe784641be225c435d0ed44
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Fri Aug 27 16:14:13 2021 +0200
templates/content-display: Remove script tag when no content to display
When a content cannot be displayed (for instance due to a too large size),
remove script tag from template to prevent execution errors.
Closes T3454See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1042/ for more details.