Page MenuHomeSoftware Heritage
Differential D6109

grammar.js: Improve grammar and export tokens
ClosedPublic
Actions

Authored by KShivendu on Aug 17 2021, 9:05 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDSEAdb47029f6c91: grammar.js: Improve grammar and export tokens
Summary
  • Export grammar tokens through tokens.js file (so that swh-web can use them)
  • Improvements in the grammar to better handle sort_by and limit
  • Introduce annotateFilter function in grammar.js to assign tree-sitter fields to different parts of a filter (field, op, value)

Diff Detail

Repository
rDSEA Archive search
Branch
export-grammar-tokens
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23059
Build 35958: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 35957: arc lint + arc unit

Event Timeline

KShivendu created this revision.Aug 17 2021, 9:05 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 17 2021, 9:05 PM
swh-public-ci added a comment.Aug 17 2021, 9:08 PM

Build is green

Patch application report for D6109 (id=22101)

Rebasing onto cad6ace509...

Current branch diff-target is up to date.
Changes applied before test
commit a76618ab8b1063fb23114195265051aba574eb80
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Aug 18 00:28:15 2021 +0530

    grammar.js: Improve grammar and export tokens
    
    Summary:
    
    - Import/Export grammar tokens through tokens.js file (so that swh-search can use them)
    - Improvements in the grammar to better handle sort_by and limit
    - Introduce annotateFilter function in grammar.js to assign tree-sitter fields to
      different parts of a filter (field, op, value)
    
    Depends on D6108
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/266/ for more details.

Harbormaster completed remote builds in B23055: Diff 22101.Aug 17 2021, 9:08 PM
KShivendu requested review of this revision.Aug 17 2021, 9:08 PM
KShivendu updated this revision to Diff 22102.Aug 17 2021, 9:13 PM
  • Improve commit message
KShivendu edited the summary of this revision. (Show Details)Aug 17 2021, 9:14 PM
KShivendu edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Aug 17 2021, 9:16 PM

Build is green

Patch application report for D6109 (id=22102)

Rebasing onto cad6ace509...

Current branch diff-target is up to date.
Changes applied before test
commit b148b3c973f4ba6ad35a50ae7f94cbfefb4b89f4
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Aug 18 00:28:15 2021 +0530

    grammar.js: Improve grammar and export tokens
    
    - Export grammar tokens through tokens.js file (so that swh-web can use them)
    - Improvements in the grammar to better handle sort_by and limit
    - Introduce annotateFilter function in grammar.js to assign tree-sitter fields to
      different parts of a filter (field, op, value)

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/267/ for more details.

Harbormaster completed remote builds in B23056: Diff 22102.Aug 17 2021, 9:17 PM
KShivendu edited the summary of this revision. (Show Details)Aug 17 2021, 9:18 PM
vlorentz added a subscriber: vlorentz.Aug 17 2021, 9:29 PM
vlorentz added inline comments.
query_language/grammar.js
1

while we're at it, this header should probably just have 2021 as date

185–186

why not function annotateFilter(field, op, value) {?

query_language/tokens.js
1

missing header

KShivendu updated this revision to Diff 22103.Aug 18 2021, 6:02 AM
  • Changes suggested by vlorentz
  • Polish the code (add comments, improve formatting)
  • Squash
swh-public-ci added a comment.Aug 18 2021, 6:06 AM

Build is green

Patch application report for D6109 (id=22103)

Rebasing onto cad6ace509...

Current branch diff-target is up to date.
Changes applied before test
commit c6d21fd64955de8b791193af007a70c228201592
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Aug 18 00:28:15 2021 +0530

    grammar.js: Improve grammar and export tokens
    
    - Export grammar tokens through tokens.js file (so that swh-web can use them)
    - Improvements in the grammar to better handle sort_by and limit
    - Introduce annotateFilter function in grammar.js to assign tree-sitter fields to
      different parts of a filter (field, op, value)

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/268/ for more details.

Harbormaster completed remote builds in B23057: Diff 22103.Aug 18 2021, 6:06 AM
KShivendu updated this revision to Diff 22105.Aug 18 2021, 8:56 AM
  • tokens.js: Use concat in fields
swh-public-ci added a comment.Aug 18 2021, 8:59 AM

Build is green

Patch application report for D6109 (id=22105)

Rebasing onto ee04e01ae0...

Current branch diff-target is up to date.
Changes applied before test
commit db47029f6c91a91395ae49b48dee142b9e0b5490
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Aug 18 00:28:15 2021 +0530

    grammar.js: Improve grammar and export tokens
    
    - Export grammar tokens through tokens.js file (so that swh-web can use them)
    - Improvements in the grammar to better handle sort_by and limit
    - Introduce annotateFilter function in grammar.js to assign tree-sitter fields to
      different parts of a filter (field, op, value)

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/269/ for more details.

Harbormaster completed remote builds in B23059: Diff 22105.Aug 18 2021, 8:59 AM
vlorentz accepted this revision.Aug 18 2021, 10:34 AM
This revision is now accepted and ready to land.Aug 18 2021, 10:34 AM
Closed by commit rDSEAdb47029f6c91: grammar.js: Improve grammar and export tokens (authored by KShivendu). · Explain WhyAug 18 2021, 11:44 AM
This revision was automatically updated to reflect the committed changes.
KShivendu added a commit: rDSEAdb47029f6c91: grammar.js: Improve grammar and export tokens.

Revision Contents
Changeset List

PathSize
query_language/
150 lines
test/
corpus/
9 lines
105 lines

Diff 22105

View Options

query_language/grammar.js

Loading...
View Options

query_language/test/corpus/combinations.txt

Loading...
View Options

query_language/tokens.js

Loading...
About · Developer information · Legal