Differential D6087

Remove shell scripts from setup.py
ClosedPublic
Actions

Authored by vlorentz on Aug 13 2021, 4:46 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDSEAb419f202530d: Remove shell scripts from setup.py

Summary

and rewrite them in Python, with error checking (instead of failing silently)

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23001
Build 35863: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35862: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 13 2021, 4:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 13 2021, 4:46 PM

Build is green

Patch application report for D6087 (id=22045)

Rebasing onto 84115fa418...

Current branch diff-target is up to date.

Changes applied before test

commit b419f202530dba95616d8227be2e2d1e6d9cfc8f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 13 16:46:48 2021 +0200

    Remove shell scripts from setup.py
    
    and rewrite them in Python, with error checking (instead of failing silently)

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/259/ for more details.

Harbormaster completed remote builds in B23001: Diff 22045.Aug 13 2021, 4:50 PM

vlorentz requested review of this revision.Aug 13 2021, 4:50 PM

douardda accepted this revision.Aug 13 2021, 4:54 PM

This revision is now accepted and ready to land.Aug 13 2021, 4:54 PM

rebase

vlorentz mentioned this in D6088: Use setup_requires to install tree-sitter.Aug 16 2021, 9:57 AM

vlorentz added a child revision: D6088: Use setup_requires to install tree-sitter.

Build is green

Patch application report for D6087 (id=22051)

Rebasing onto 84115fa418...

Current branch diff-target is up to date.

Changes applied before test

commit b419f202530dba95616d8227be2e2d1e6d9cfc8f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 13 16:46:48 2021 +0200

    Remove shell scripts from setup.py
    
    and rewrite them in Python, with error checking (instead of failing silently)

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/262/ for more details.

Harbormaster completed remote builds in B23007: Diff 22051.Aug 16 2021, 10:01 AM

Closed by commit rDSEAb419f202530d: Remove shell scripts from setup.py (authored by vlorentz). · Explain WhyAug 16 2021, 5:47 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSEAb419f202530d: Remove shell scripts from setup.py.