Page MenuHomeSoftware Heritage

converters: Preserve GPG signatures on releases
ClosedPublic

Authored by vlorentz on Jul 30 2021, 10:56 AM.

Details

Summary

Since version 0.19.10 (more specifically, this commit:
https://github.com/dulwich/dulwich/commit/72aec0c79fb395689e40f9228df93e2a39cf8fb0),
Dulwich strips GPG signatures from the 'message' attribute of Tag objects,
and stores it in a new attribute, 'signature'.

This means we were silently dropping all signatures from releases.

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6045 (id=21866)

Rebasing onto 9e52708e8c...

Current branch diff-target is up to date.
Changes applied before test
commit c67ab0269ef2ed4e87799f0140e1358a9a0ddce4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 10:53:53 2021 +0200

    converters: Preserve GPG signatures on releases
    
    Since version 0.19.10 (more specifically, this commit:
    <https://github.com/dulwich/dulwich/commit/72aec0c79fb395689e40f9228df93e2a39cf8fb0>),
    Dulwich strips GPG signatures from the 'message' attribute of Tag objects,
    and stores it in a new attribute, 'signature'.
    
    This means we were silently dropping all signatures from releases.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/101/ for more details.

This revision is now accepted and ready to land.Jul 30 2021, 11:31 AM