Differential D6045

converters: Preserve GPG signatures on releases
ClosedPublic
Actions

Authored by vlorentz on Jul 30 2021, 10:56 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3135: Improve integrity of ingested content

Commits

rDLDGc67ab0269ef2: converters: Preserve GPG signatures on releases

Summary

Since version 0.19.10 (more specifically, this commit:
https://github.com/dulwich/dulwich/commit/72aec0c79fb395689e40f9228df93e2a39cf8fb0),
Dulwich strips GPG signatures from the 'message' attribute of Tag objects,
and stores it in a new attribute, 'signature'.

This means we were silently dropping all signatures from releases.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 30 2021, 10:56 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 30 2021, 10:56 AM

Build is green

Patch application report for D6045 (id=21866)

Rebasing onto 9e52708e8c...

Current branch diff-target is up to date.

Changes applied before test

commit c67ab0269ef2ed4e87799f0140e1358a9a0ddce4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 30 10:53:53 2021 +0200

    converters: Preserve GPG signatures on releases
    
    Since version 0.19.10 (more specifically, this commit:
    <https://github.com/dulwich/dulwich/commit/72aec0c79fb395689e40f9228df93e2a39cf8fb0>),
    Dulwich strips GPG signatures from the 'message' attribute of Tag objects,
    and stores it in a new attribute, 'signature'.
    
    This means we were silently dropping all signatures from releases.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/101/ for more details.

Harbormaster completed remote builds in B22827: Diff 21866.Jul 30 2021, 10:57 AM

vlorentz requested review of this revision.Jul 30 2021, 10:57 AM

vlorentz added a task: T75: Check integrity of directories, revisions, and releases.Jul 30 2021, 10:58 AM

vlorentz edited tasks, added T3135: Improve integrity of ingested content; removed T75: Check integrity of directories, revisions, and releases.

vlorentz mentioned this in T75: Check integrity of directories, revisions, and releases.