Page MenuHomeSoftware Heritage
Differential D5969

templates/snapshot-context: Visit origin URL in a new browser tab
ClosedPublic
Actions

Authored by anlambert on Jul 6 2021, 12:00 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPSe12202c4b373: templates/snapshot-context: Visit origin URL in a new browser tab
Summary

When clicking on the "Go to origin" icon, open a new browser tab to
keep Software Heritage one.

Depends on D5982

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22479
Build 35016: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 35015: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
407 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.common.test_archive::Tests / Python tests / test_lookup_origins_get_by_sha1s
@given(origin(), new_origin()) > def test_lookup_origins_get_by_sha1s(origin, unknown_origin):
215 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
264 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_authorized_origin_url
125 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_unauthorized_origin_url
128 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_reject_pending_save_request
View Full Test Results (1 Failed · 712 Passed · 5 Skipped)

Event Timeline

anlambert created this revision.Jul 6 2021, 12:00 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 6 2021, 12:00 PM
swh-public-ci added a comment.Jul 6 2021, 12:18 PM

Build has FAILED

Patch application report for D5969 (id=21506)

Rebasing onto 7759503780...

Current branch diff-target is up to date.
Changes applied before test
commit cfeb5acc640b811ec488685ed8aea66633af4e9f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/925/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/925/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 6 2021, 12:18 PM
Harbormaster failed remote builds in B22479: Diff 21506!
anlambert updated this revision to Diff 21512.Jul 6 2021, 2:46 PM

Rebase

swh-public-ci added a comment.Jul 6 2021, 3:04 PM

Build is green

Patch application report for D5969 (id=21512)

Rebasing onto 36b44ef08e...

Current branch diff-target is up to date.
Changes applied before test
commit c62ce202d502df8e3b4ed486ebe91bd0083c21c3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/927/ for more details.

Harbormaster completed remote builds in B22485: Diff 21512.Jul 6 2021, 3:04 PM
anlambert requested review of this revision.Jul 6 2021, 3:04 PM
ardumont accepted this revision.Jul 8 2021, 1:30 PM
This revision is now accepted and ready to land.Jul 8 2021, 1:30 PM
anlambert updated this revision to Diff 21560.Jul 8 2021, 4:32 PM

Update:

  • Rebase
  • Open origin in browser tab in save code now UI too
swh-public-ci added a comment.Jul 8 2021, 4:52 PM

Build has FAILED

Patch application report for D5969 (id=21560)

Rebasing onto 25c639f292...

Current branch diff-target is up to date.
Changes applied before test
commit cc1cc338361b4f517355b972d40b5b261263e925
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/954/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/954/console

Harbormaster failed remote builds in B22534: Diff 21560!Jul 8 2021, 4:52 PM
swh-public-ci added a comment.Jul 8 2021, 5:18 PM

Build has FAILED

Patch application report for D5969 (id=21560)

Rebasing onto 25c639f292...

Current branch diff-target is up to date.
Changes applied before test
commit cc1cc338361b4f517355b972d40b5b261263e925
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/955/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/955/console

swh-public-ci added a comment.Jul 8 2021, 5:45 PM

Build has FAILED

Patch application report for D5969 (id=21560)

Rebasing onto 25c639f292...

Current branch diff-target is up to date.
Changes applied before test
commit cc1cc338361b4f517355b972d40b5b261263e925
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/956/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/956/console

anlambert edited the summary of this revision. (Show Details)Jul 8 2021, 7:36 PM
anlambert added a parent revision: D5982: cypress/layout: Fix cypress anti-pattern use.
anlambert updated this revision to Diff 21564.Jul 8 2021, 7:37 PM

Rebase on top of D5982 fixing flaky cypress test

swh-public-ci added a comment.Jul 8 2021, 7:53 PM

Build is green

Patch application report for D5969 (id=21564)

Could not rebase; Attempt merge onto 25c639f292...

Updating 25c639f2..e12202c4
Fast-forward
 assets/src/bundles/admin/origin-save.js          |  3 ++-
 assets/src/bundles/save/index.js                 |  3 ++-
 cypress/integration/layout.spec.js               | 18 ++++++++++++------
 cypress/integration/origin-save.spec.js          |  2 +-
 swh/web/templates/includes/snapshot-context.html |  3 ++-
 5 files changed, 19 insertions(+), 10 deletions(-)
Changes applied before test
commit e12202c4b3730568477b25d91f07f45098e9f188
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

commit a9688b3a981847d71c56e340c25f743c94a8d85a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Jul 8 19:08:14 2021 +0200

    cypress/layout: Fix cypress anti-pattern use
    
    Cypress commands should not be invoked in a loop as it is an anti-pattern
    that can produce flaky tests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/958/ for more details.

Harbormaster completed remote builds in B22538: Diff 21564.Jul 8 2021, 7:53 PM
Closed by commit rDWAPPSe12202c4b373: templates/snapshot-context: Visit origin URL in a new browser tab (authored by anlambert). · Explain WhyJul 9 2021, 12:20 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSe12202c4b373: templates/snapshot-context: Visit origin URL in a new browser tab.

Revision Contents
Changeset List

PathSize
swh/
web/
templates/
includes/
3 lines

Diff 21506

View Options

swh/web/templates/includes/snapshot-context.html

Loading...
About · Developer information · Legal