Differential D5959

assets/diff-utils: Use homemade missing new line icon instead of GH one
ClosedPublic
Actions

Authored by anlambert on Jul 1 2021, 6:10 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS3c06b0331d4c: assets/diff-utils: Use homemade missing new line icon instead of GH one

Summary

Create a missing new line at end of file icon by combining two Material Design
ones instead of reusing a SVG copy of the old GitHub one.

This removes a copyright infringement while having a better looking icon.

For the record, I also noticed flaws in the way I implemented the display of that
icon in diff views and the feature also misses a cypress test.
I will handle that in another diff.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22391
Build 34875: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 34874: arc lint + arc unit

Event Timeline

anlambert created this revision.Jul 1 2021, 6:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 1 2021, 6:10 PM

anlambert edited the summary of this revision. (Show Details)Jul 1 2021, 6:12 PM

Build was aborted

Patch application report for D5959 (id=21412)

Rebasing onto 8af28bab94...

Current branch diff-target is up to date.

Changes applied before test

commit 3c06b0331d4c42512cbf8572c2abcba855752039
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Jul 1 18:04:54 2021 +0200

    assets/diff-utils: Use homemade missing new line icon instead of GH one
    
    Create a missing new line at end of file icon by combining two Material Design
    ones instead of reusing a SVG copy of the old GitHub one.
    
    This removes a copyright infringement while having a better looking icon.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/920/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/920/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2021, 6:31 PM

Harbormaster failed remote builds in B22391: Diff 21412!

Build is green

Patch application report for D5959 (id=21412)

Rebasing onto 8af28bab94...

Current branch diff-target is up to date.

Changes applied before test

commit 3c06b0331d4c42512cbf8572c2abcba855752039
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Jul 1 18:04:54 2021 +0200

    assets/diff-utils: Use homemade missing new line icon instead of GH one
    
    Create a missing new line at end of file icon by combining two Material Design
    ones instead of reusing a SVG copy of the old GitHub one.
    
    This removes a copyright infringement while having a better looking icon.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/921/ for more details.

Harbormaster completed remote builds in B22391: Diff 21412.Jul 1 2021, 6:59 PM

anlambert requested review of this revision.Jul 1 2021, 6:59 PM