Page MenuHomeSoftware Heritage

eslint: Activate prefer-const rule and apply fixes
ClosedPublic

Authored by anlambert on Jul 1 2021, 11:30 AM.

Details

Summary

Ensure to declare a variable with const when it is not reassigned.

Diff Detail

Repository
rDWAPPS Web applications
Branch
assets-let-to-const
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22361
Build 34818: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 34817: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D5953 (id=21382)

Rebasing onto 4d1963a748...

Current branch diff-target is up to date.
Changes applied before test
commit 8af28bab9467f487f021ee543c20b92ce1634b90
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jun 30 14:10:54 2021 +0200

    eslint: Activate prefer-const rule and apply fixes
    
    Ensure to declare a variable with const when it is not reassigned.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/917/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/917/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2021, 11:48 AM
Harbormaster failed remote builds in B22361: Diff 21382!

Build is green

Patch application report for D5953 (id=21382)

Rebasing onto 4d1963a748...

Current branch diff-target is up to date.
Changes applied before test
commit 8af28bab9467f487f021ee543c20b92ce1634b90
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jun 30 14:10:54 2021 +0200

    eslint: Activate prefer-const rule and apply fixes
    
    Ensure to declare a variable with const when it is not reassigned.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/918/ for more details.

This revision is now accepted and ready to land.Jul 1 2021, 1:47 PM