Differential D5938

Make swh.graph dependency optional 2/2
ClosedPublic
Actions

Authored by ardumont on Jun 29 2021, 10:35 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T843: Vault: Add a "git bare" tarball cooker
T3412: Deploy vault "git bare" tarball cooker (swh-vault v0.6)

Commits

rDVAU04b174efc79f: Make swh.graph dependency optional 2/2

Summary

Those were missed in the first part of the implementation. They got revealed by the
debian build.

Related to T3412
Related to D5935

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22305
Build 34716: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 34715: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 29 2021, 10:35 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 29 2021, 10:35 AM

ardumont added inline comments.Jun 29 2021, 10:35 AM

swh/vault/tests/test_git_bare_cooker.py
124	It will get excluded in the debian build.

Build is green

Patch application report for D5938 (id=21324)

Rebasing onto 9d0df34d41...

Current branch diff-target is up to date.

Changes applied before test

commit 04b174efc79f5d6449c1dd8d94b3d19852e47be3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jun 29 10:33:11 2021 +0200

    Make swh.graph dependency optional 2/2
    
    Those were missed in the first part of the implementation. They got revealed by the
    debian build.
    
    Related to T3412

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/126/ for more details.

Harbormaster completed remote builds in B22305: Diff 21324.Jun 29 2021, 10:37 AM

ardumont requested review of this revision.Jun 29 2021, 10:37 AM

ardumont edited the summary of this revision. (Show Details)Jun 29 2021, 11:00 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 29 2021, 11:08 AM

Closed by commit rDVAU04b174efc79f: Make swh.graph dependency optional 2/2 (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDVAU04b174efc79f: Make swh.graph dependency optional 2/2.

ardumont mentioned this in T3412: Deploy vault "git bare" tarball cooker (swh-vault v0.6).Jun 29 2021, 11:27 AM

vlorentz added a task: T843: Vault: Add a "git bare" tarball cooker.Aug 2 2021, 1:56 PM