Page MenuHomeSoftware Heritage
Differential D5921

Make api_raw_extrinsic_metadata_get set Content-disposition
ClosedPublic
Actions

Authored by vlorentz on Jun 25 2021, 11:16 AM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T2938: Create API endpoint to access raw_extrinsic_metadata
Summary

So metadata files are always downloaded as attachment (when accessed from a browser),
and has a filename that contains the SWHID of the metadata target.

Depends on D5875.

Diff Detail

Unit TestsFailed
View All

TimeTest
10,663 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_metadata::Tests / Python tests / test_api_raw_extrinsic_metadata
api_client = <rest_framework.test.APIClient object at 0x7f8095f970f0> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7f8095450f60>
15,689 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_metadata::Tests / Python tests / test_api_raw_extrinsic_metadata_scroll[100]
api_client = <rest_framework.test.APIClient object at 0x7f8094008c88> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7f8095450f60> limit = 100
3,009 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_metadata::Tests / Python tests / test_api_raw_extrinsic_metadata_scroll[10]
api_client = <rest_framework.test.APIClient object at 0x7f8095fd24e0> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7f8095450f60> limit = 10
3,061 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_metadata::Tests / Python tests / test_api_raw_extrinsic_metadata_scroll[1]
api_client = <rest_framework.test.APIClient object at 0x7f8094079668> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7f8095450f60> limit = 1
2,434 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_metadata::Tests / Python tests / test_api_raw_extrinsic_metadata_scroll[2]
api_client = <rest_framework.test.APIClient object at 0x7f8096d6eac8> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7f8095450f60> limit = 2
View Full Test Results (5 Failed · 697 Passed · 5 Skipped)

Event Timeline

vlorentz created this revision.Jun 25 2021, 11:16 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 25 2021, 11:16 AM
swh-public-ci added a comment.Jun 25 2021, 11:18 AM

Build has FAILED

Patch application report for D5921 (id=21257)

Could not rebase; Attempt merge onto 1bd55d031e...

Updating 1bd55d03..4c845f1e
Fast-forward
 swh/web/api/urls.py                      |   1 +
 swh/web/api/views/metadata.py            | 191 +++++++++++++++++++++++++++++++
 swh/web/common/converters.py             |  20 +++-
 swh/web/tests/api/views/test_metadata.py | 139 ++++++++++++++++++++++
 swh/web/tests/api/views/test_origin.py   |  33 +-----
 swh/web/tests/api/views/utils.py         |  33 ++++++
 swh/web/tests/common/test_converters.py  |   2 +-
 7 files changed, 385 insertions(+), 34 deletions(-)
 create mode 100644 swh/web/api/views/metadata.py
 create mode 100644 swh/web/tests/api/views/test_metadata.py
 create mode 100644 swh/web/tests/api/views/utils.py
Changes applied before test
commit 4c845f1e6872976584332f5c7f08cff1fc2461a5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 11:16:22 2021 +0200

    Make api_raw_extrinsic_metadata_get set Content-disposition
    
    So metadata files are always downloaded as attachment (when accessed from a browser),
    and has a filename that contains the SWHID of the metadata target.

commit 00f08cea038d6d5e1ed6998db4ba9c61b18ec399
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 15 16:49:53 2021 +0200

    Add an endpoint to list and access raw extrinsic metadata.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/894/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/894/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 25 2021, 11:18 AM
Harbormaster failed remote builds in B22238: Diff 21257!
swh-public-ci added a comment.Jun 25 2021, 11:41 AM

Build has FAILED

Patch application report for D5921 (id=21257)

Could not rebase; Attempt merge onto 1bd55d031e...

Updating 1bd55d03..4c845f1e
Fast-forward
 swh/web/api/urls.py                      |   1 +
 swh/web/api/views/metadata.py            | 191 +++++++++++++++++++++++++++++++
 swh/web/common/converters.py             |  20 +++-
 swh/web/tests/api/views/test_metadata.py | 139 ++++++++++++++++++++++
 swh/web/tests/api/views/test_origin.py   |  33 +-----
 swh/web/tests/api/views/utils.py         |  33 ++++++
 swh/web/tests/common/test_converters.py  |   2 +-
 7 files changed, 385 insertions(+), 34 deletions(-)
 create mode 100644 swh/web/api/views/metadata.py
 create mode 100644 swh/web/tests/api/views/test_metadata.py
 create mode 100644 swh/web/tests/api/views/utils.py
Changes applied before test
commit 4c845f1e6872976584332f5c7f08cff1fc2461a5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 11:16:22 2021 +0200

    Make api_raw_extrinsic_metadata_get set Content-disposition
    
    So metadata files are always downloaded as attachment (when accessed from a browser),
    and has a filename that contains the SWHID of the metadata target.

commit 00f08cea038d6d5e1ed6998db4ba9c61b18ec399
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 15 16:49:53 2021 +0200

    Add an endpoint to list and access raw extrinsic metadata.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/896/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/896/console

vlorentz updated this revision to Diff 21262.Jun 25 2021, 12:45 PM

rebase

swh-public-ci added a comment.Jun 25 2021, 1:13 PM

Build has FAILED

Patch application report for D5921 (id=21262)

Could not rebase; Attempt merge onto 1bd55d031e...

Updating 1bd55d03..b4e21acc
Fast-forward
 requirements-swh.txt                     |   4 +-
 swh/web/api/urls.py                      |   1 +
 swh/web/api/views/metadata.py            | 191 +++++++++++++++++++++++++++++++
 swh/web/common/converters.py             |  20 +++-
 swh/web/tests/api/views/test_metadata.py | 139 ++++++++++++++++++++++
 swh/web/tests/api/views/test_origin.py   |  33 +-----
 swh/web/tests/api/views/utils.py         |  33 ++++++
 swh/web/tests/common/test_converters.py  |   2 +-
 8 files changed, 387 insertions(+), 36 deletions(-)
 create mode 100644 swh/web/api/views/metadata.py
 create mode 100644 swh/web/tests/api/views/test_metadata.py
 create mode 100644 swh/web/tests/api/views/utils.py
Changes applied before test
commit b4e21accf91f4da359c174ea0d4bc6a4fb0d749a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 11:16:22 2021 +0200

    Make api_raw_extrinsic_metadata_get set Content-disposition
    
    So metadata files are always downloaded as attachment (when accessed from a browser),
    and has a filename that contains the SWHID of the metadata target.

commit 785719a16a25bed9967c5086e781b77dc09e89f5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 15 16:49:53 2021 +0200

    Add an endpoint to list and access raw extrinsic metadata.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/902/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/902/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 25 2021, 1:13 PM
Harbormaster failed remote builds in B22243: Diff 21262!
vlorentz updated this revision to Diff 21288.Jun 25 2021, 4:21 PM

rebase

vlorentz added a task: T2938: Create API endpoint to access raw_extrinsic_metadata.Jun 25 2021, 4:26 PM
swh-public-ci added a comment.Jun 25 2021, 4:51 PM

Build is green

Patch application report for D5921 (id=21288)

Could not rebase; Attempt merge onto f9f1e969e9...

Merge made by the 'recursive' strategy.
 requirements-swh.txt                     |   4 +-
 swh/web/api/urls.py                      |   1 +
 swh/web/api/views/metadata.py            | 191 +++++++++++++++++++++++++++++++
 swh/web/common/converters.py             |  20 +++-
 swh/web/tests/api/views/test_metadata.py | 139 ++++++++++++++++++++++
 swh/web/tests/api/views/test_origin.py   |  33 +-----
 swh/web/tests/api/views/utils.py         |  33 ++++++
 swh/web/tests/common/test_converters.py  |   2 +-
 8 files changed, 387 insertions(+), 36 deletions(-)
 create mode 100644 swh/web/api/views/metadata.py
 create mode 100644 swh/web/tests/api/views/test_metadata.py
 create mode 100644 swh/web/tests/api/views/utils.py
Changes applied before test
commit 0d8a43aa8ebb924bcff916fdcc5780c79a305685
Merge: f9f1e969 cb308cdb
Author: Jenkins user <jenkins@localhost>
Date:   Fri Jun 25 14:36:07 2021 +0000

    Merge branch 'diff-target' into HEAD

commit cb308cdbc45ec89972a692e761dbfc4bed18f6b7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 11:16:22 2021 +0200

    Make api_raw_extrinsic_metadata_get set Content-disposition
    
    So metadata files are always downloaded as attachment (when accessed from a browser),
    and has a filename that contains the SWHID of the metadata target.

commit 722ac6036890abc63cbe1ffb70e79feabebb4311
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 15 16:49:53 2021 +0200

    Add an endpoint to list and access raw extrinsic metadata.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/906/ for more details.

Harbormaster completed remote builds in B22266: Diff 21288.Jun 25 2021, 4:51 PM
vlorentz requested review of this revision.Jun 25 2021, 4:51 PM
anlambert accepted this revision.Jun 25 2021, 4:52 PM
This revision is now accepted and ready to land.Jun 25 2021, 4:52 PM
vlorentz closed this revision.Jun 25 2021, 4:53 PM

0de60f0f4d8f3cd68cd703cb20fa611750185b77

Revision Contents
Changeset List

PathSize
swh/
web/
api/
views/
16 lines
tests/
api/
views/
4 lines

Diff 21262

View Options

swh/web/api/views/metadata.py

Loading...
View Options

swh/web/tests/api/views/test_metadata.py

Loading...
About · Developer information · Legal