Page MenuHomeSoftware Heritage

Make mappings into a hierarchy of classes that can be easily extended.
ClosedPublic

Authored by vlorentz on Oct 24 2018, 6:37 PM.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz retitled this revision from Summary: to Implement all mappings.Oct 24 2018, 6:37 PM
vlorentz retitled this revision from Implement all mappings to Make mappings into a hierarchy of classes that can be easily extended..

I need some more time to play with this diff before accepting it

swh/indexer/data/codemeta/crosswalk.csv
1 ↗(On Diff #1809)

We should reference this file with a citation, maybe in the docs.
I should add that to my task T794

swh/indexer/metadata_dictionary.py
71

This is a really nice way to do it

This comment was removed by vlorentz.
This comment was removed by vlorentz.
vlorentz added inline comments.
swh/indexer/data/codemeta/crosswalk.csv
1 ↗(On Diff #1809)

Let's add a new file swh/indexer/data/codemeta/README?

moranegg added a subscriber: ardumont.

I'm accepting this diff- it looks great.
Nevertheless, I think there should be at least one test for CodeMeta (even without the json-ld resolution)
and I added a comment about the tool version.

Concerning the citation/documentation of CodeMeta, I will add this information in a README, in the data directory as you suggested, next week.

Anyway I think you are ready for deployment, which is better to do today than tomorrow, especially because @ardumont is on leave next week.

swh/indexer/sql/50-swh-data.sql
21

the version in the diff is 0.0.2
as we never deployed the metadata indexers in production, I think we don't need to keep entries of '0.0.1'

This revision is now accepted and ready to land.Oct 25 2018, 1:51 PM
vlorentz marked an inline comment as done.
  • Rebase
This revision was automatically updated to reflect the committed changes.