swh-model: encode exclude patterns before extracting regex objects
ClosedPublic
Actions

Authored by DanSeraf on Jun 15 2021, 5:40 PM.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T3383: swh identify --recursive breaks --exclude, resulting in a "AttributeError: 'str' object has no attribute 'decode'" traceback

Commits

rDMODe09446a6f44b: encode exclude patterns before extracting regex objects

Summary

add related typing annotations

Related to T3383

Diff Detail

Repository

rDMOD Data model

Branch

exclude-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22043
Build 34286: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 34285: arc lint + arc unit

Event Timeline

DanSeraf created this revision.Jun 15 2021, 5:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 15 2021, 5:40 PM

Build has FAILED

Patch application report for D5876 (id=21049)

Rebasing onto 8ec0cf685b...

Current branch diff-target is up to date.

Changes applied before test

commit 4cc6dc8adba57ffea7208619cec4f0a40e23fba3
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jun 15 16:30:41 2021 +0100

    encode exclude patterns before extracting regex objects
    
    - add typing annotation to avoid such error in the future

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/351/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/351/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 15 2021, 5:41 PM

Harbormaster failed remote builds in B22040: Diff 21049!

DanSeraf edited the summary of this revision. (Show Details)Jun 15 2021, 5:42 PM

DanSeraf added a task: T3383: swh identify --recursive breaks --exclude, resulting in a "AttributeError: 'str' object has no attribute 'decode'" traceback.

make mypy pass

Build is green

Patch application report for D5876 (id=21050)

Rebasing onto 8ec0cf685b...

Current branch diff-target is up to date.

Changes applied before test

commit fe731f4acacbf3d1819cecc82f9e69992c5e6a6b
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jun 15 16:30:41 2021 +0100

    encode exclude patterns before extracting regex objects
    
    - add typing annotation to avoid such error in the future

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/352/ for more details.

Harbormaster completed remote builds in B22041: Diff 21050.Jun 15 2021, 5:53 PM

DanSeraf requested review of this revision.Jun 15 2021, 5:53 PM

lgtm

Thanks.

This revision is now accepted and ready to land.Jun 15 2021, 6:05 PM

commit message

Build is green

Patch application report for D5876 (id=21052)

Rebasing onto 8ec0cf685b...

Current branch diff-target is up to date.

Changes applied before test

commit e09446a6f44b9070ea70a9760bc82dee0bbcb687
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jun 15 16:30:41 2021 +0100

    encode exclude patterns before extracting regex objects
    
    - add typing annotation to avoid such error in the future
    
    Fixes T3383

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/353/ for more details.

Harbormaster completed remote builds in B22043: Diff 21052.Jun 15 2021, 6:27 PM

Closed by commit rDMODe09446a6f44b: encode exclude patterns before extracting regex objects (authored by DanSeraf). · Explain WhyJun 15 2021, 6:28 PM

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDMODe09446a6f44b: encode exclude patterns before extracting regex objects.