Differential D5846

Refactor and extract a get_available_slots utility
ClosedPublic
Actions

Authored by ardumont on Jun 10 2021, 12:17 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T3367: scheduler: Separate scheduling save code now tasks from the recurrent tasks

Commits

rDSCH21c4279b9998: Refactor and extract a get_available_slots utility

Summary

This adds coverage as well. This will be needed for subsidiary diffs.

Related to T3367

Test Plan

tox

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21887
Build 34033: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 34032: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 10 2021, 12:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 10 2021, 12:17 PM

Build is green

Patch application report for D5846 (id=20905)

Rebasing onto 9d2618db8f...

Current branch diff-target is up to date.

Changes applied before test

commit 21c4279b9998e884d3b08a8f300c77f608f458b0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jun 10 12:15:22 2021 +0200

    Refactor and extract a get_available_slots utility
    
    This adds coverage as well. This will be needed for subsidiary diffs.
    
    Related to T3367

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/360/ for more details.

Harbormaster completed remote builds in B21887: Diff 20905.Jun 10 2021, 12:19 PM

ardumont requested review of this revision.Jun 10 2021, 12:19 PM

olasd accepted this revision.Jun 10 2021, 12:24 PM

This revision is now accepted and ready to land.Jun 10 2021, 12:24 PM

Closed by commit rDSCH21c4279b9998: Refactor and extract a get_available_slots utility (authored by ardumont). · Explain WhyJun 10 2021, 12:25 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH21c4279b9998: Refactor and extract a get_available_slots utility.

ardumont mentioned this in D5818: send-to-celery: Add more options to allow scheduling of edge case origins.Jun 11 2021, 12:42 PM