Page MenuHomeSoftware Heritage

requirements: Cleanup and normalize
ClosedPublic

Authored by anlambert on Jun 9 2021, 2:20 PM.

Details

Summary

Use lowercase only for requirement names and sort them in
lexicographical order.

Move types-* in requirements-test.txt files as they are not
required for execution and produce errors in docker:

swh-loader_1                    | Waiting for RabbitMQ to start
swh-loader_1                    | wait-for-it: waiting for amqp:5672 without a timeout
swh-loader_1                    | wait-for-it: amqp:5672 is available after 0 seconds
swh-loader_1                    | Register task types in scheduler database
swh-loader_1                    | wait-for-it: waiting for swh-scheduler:5008 without a timeout
swh-loader_1                    | wait-for-it: swh-scheduler:5008 is available after 0 seconds
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand vault: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand storage: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand search: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand scheduler: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand scheduler-journal: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand objstorage: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand loader: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand lister: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand indexer: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand deposit: The 'types-Flask' distribution was not found and is required by swh.core
swh-loader_1                    | WARNING:swh.core.cli:Could not load subcommand counters: The 'types-Flask' distribution was not found and is required by swh.core

Remove no longer used requirements-test-db.txt file and associated
testing-db extra in setup.py.

(swh) ✔ ~/swh/swh-environment [make-package-fixes L|✚ 1⚑ 13] 
14:19 $ mr grep testing-db
mr grep: /home/anlambert/swh/swh-environment/snippets

mr grep: /home/anlambert/swh/swh-environment/swh-auth

mr grep: /home/anlambert/swh/swh-environment/swh-core

mr grep: /home/anlambert/swh/swh-environment/swh-counters

mr grep: /home/anlambert/swh/swh-environment/swh-dataset

mr grep: /home/anlambert/swh/swh-environment/swh-deposit

mr grep: /home/anlambert/swh/swh-environment/swh-docs

mr grep: /home/anlambert/swh/swh-environment/swh-fuse

mr grep: /home/anlambert/swh/swh-environment/swh-graph

mr grep: /home/anlambert/swh/swh-environment/swh-icinga-plugins

mr grep: /home/anlambert/swh/swh-environment/swh-indexer

mr grep: /home/anlambert/swh/swh-environment/swh-journal

mr grep: /home/anlambert/swh/swh-environment/swh-lister

mr grep: /home/anlambert/swh/swh-environment/swh-loader-core

mr grep: /home/anlambert/swh/swh-environment/swh-loader-git

mr grep: /home/anlambert/swh/swh-environment/swh-loader-mercurial

mr grep: /home/anlambert/swh/swh-environment/swh-loader-svn

mr grep: /home/anlambert/swh/swh-environment/swh-model

mr grep: /home/anlambert/swh/swh-environment/swh-objstorage

mr grep: /home/anlambert/swh/swh-environment/swh-objstorage-replayer

mr grep: /home/anlambert/swh/swh-environment/swh-py-template

mr grep: /home/anlambert/swh/swh-environment/swh-scanner

mr grep: /home/anlambert/swh/swh-environment/swh-scheduler

mr grep: /home/anlambert/swh/swh-environment/swh-search

mr grep: /home/anlambert/swh/swh-environment/swh-storage

mr grep: /home/anlambert/swh/swh-environment/swh-vault

mr grep: /home/anlambert/swh/swh-environment/swh-web

mr grep: /home/anlambert/swh/swh-environment/swh-web-client

mr grep: finished (28 ok)

Diff Detail

Event Timeline

Build is green

Patch application report for D5837 (id=20876)

Rebasing onto 55a2244135...

Current branch diff-target is up to date.
Changes applied before test
commit da428ab877580239771eba58bba942a342daa467
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 9 14:15:32 2021 +0200

    requirements: Cleanup and normalize
    
    Use lowercase only for requirement names and sort them in
    lexicographical order.
    
    Move types-* in requirements-test.txt files as they are not
    required for execution.
    
    Remove no longer used requirements-test-db.txt file and associated
    testing-db extra in setup.py.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/228/ for more details.

ardumont added a subscriber: ardumont.

Fix one stuff, break another, fix another, break yet another... overall, this feels like a whack-a-moll game ;)

This revision is now accepted and ready to land.Jun 9 2021, 2:27 PM

Fix one stuff, break another, fix another, break yet another... overall, this feels like a whack-a-moll game ;)

Yeah, not fun but must be done.

This revision was automatically updated to reflect the committed changes.