Differential D5744

Fix crash on 'PUT Col-IRI'
ClosedPublic
Actions

Authored by vlorentz on May 17 2021, 2:21 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP5719c59390e3: Fix crash on 'PUT Col-IRI'

Summary

The default implementation in APIBase expect all endpoints to have 'collection'
and 'deposit_id' set, but 'deposit_id' is not set when 'PUT Col-IRI' is used.

Resolves Sentry issue SWH-DEPOSIT-24

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21515
Build 33427: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 33426: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 17 2021, 2:21 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 17 2021, 2:21 PM

Build is green

Patch application report for D5744 (id=20535)

Rebasing onto 70f9c14137...

Current branch diff-target is up to date.

Changes applied before test

commit 5719c59390e30bf738dc63797518ecc6d8cf90a9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon May 17 14:20:59 2021 +0200

    Fix crash on 'PUT Col-IRI'
    
    The default implementation in APIBase expect all endpoints to have 'collection'
    and 'deposit_id' set, but 'deposit_id' is not set when 'PUT Col-IRI' is used.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/647/ for more details.

Harbormaster completed remote builds in B21515: Diff 20535.May 17 2021, 2:25 PM

vlorentz requested review of this revision.May 17 2021, 2:25 PM

ardumont accepted this revision.May 17 2021, 2:57 PM

This revision is now accepted and ready to land.May 17 2021, 2:57 PM

Closed by commit rDDEP5719c59390e3: Fix crash on 'PUT Col-IRI' (authored by vlorentz). · Explain WhyMay 17 2021, 3:18 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP5719c59390e3: Fix crash on 'PUT Col-IRI'.