Differential D5663

assets/save: Fix save code now request creation for authenticated users
ClosedPublic
Actions

Authored by anlambert on May 3 2021, 3:56 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS97d077ffd3e7: assets/save: Fix save code now request creation for authenticated users

Summary

The regression was introduced in f9b0b666d512564fddfc2fda65b2975fa0ea75c3.

Add a cypress test to cover that case.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 3 2021, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 3 2021, 3:56 PM

good catch!

This revision is now accepted and ready to land.May 3 2021, 4:01 PM

This revision was landed with ongoing or failed builds.May 3 2021, 4:03 PM

Closed by commit rDWAPPS97d077ffd3e7: assets/save: Fix save code now request creation for authenticated users (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS97d077ffd3e7: assets/save: Fix save code now request creation for authenticated users.

Build is green

Patch application report for D5663 (id=20228)

Rebasing onto 36740a0fd9...

Current branch diff-target is up to date.

Changes applied before test

commit 97d077ffd3e7b75b234d815c53cf42675898bd0a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon May 3 15:55:07 2021 +0200

    assets/save: Fix save code now request creation for authenticated users
    
    The regression was introduced in f9b0b666d512564fddfc2fda65b2975fa0ea75c3.
    
    Add a cypress test to cover that case.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/765/ for more details.

Harbormaster completed remote builds in B21216: Diff 20228.May 3 2021, 4:06 PM