Differential D5661

Save code now: Do not check origins for existence
ClosedPublic
Actions

Authored by ardumont on May 3 2021, 2:46 PM.

Details

Reviewers

anlambert

Maniphest Tasks

T3213: Enable save code now of software source code archives for specific users

Commits

rDWAPPS36740a0fd9b0: Save code now: Do not check origins for existence

Summary

This check will only work for existing origin visit types (svn, hg, git) which are
behind a frontend.

This will be re-opened soon but restricted to the new incoming bundle visit type (for
the associated artifacts).

Related to T3213

Test Plan

tox

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21212
Build 32931: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32930: arc lint + arc unit

Event Timeline

ardumont created this revision.May 3 2021, 2:46 PM

Drop some more missed assertions the first time around

Build is green

Patch application report for D5661 (id=20221)

Rebasing onto 8439eb5c9b...

Current branch diff-target is up to date.

Changes applied before test

commit f4c36fb5d4d63b953d738c9fe9cf93532b2b9d69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 3 14:23:52 2021 +0200

    Save code now: Do not check origins for existence
    
    This check will only work for existing origin visit types (svn, hg, git) which are
    behind a frontend.
    
    This will be re-opened soon but restricted to the new incoming bundle visit type (for
    the associated artifacts).
    
    Related to T3213

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/763/ for more details.

Harbormaster completed remote builds in B21211: Diff 20221.May 3 2021, 2:56 PM

Build is green

Patch application report for D5661 (id=20222)

Rebasing onto 8439eb5c9b...

Current branch diff-target is up to date.

Changes applied before test

commit 36740a0fd9b03d08772ccd1ec50c8d3690c6978f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 3 14:23:52 2021 +0200

    Save code now: Do not check origins for existence
    
    This check will only work for existing origin visit types (svn, hg, git) which are
    behind a frontend.
    
    This will be re-opened soon but restricted to the new incoming bundle visit type (for
    the associated artifacts).
    
    Related to T3213

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/764/ for more details.

Harbormaster completed remote builds in B21212: Diff 20222.May 3 2021, 3:05 PM

ardumont requested review of this revision.May 3 2021, 3:05 PM

Looks good to me.

This revision is now accepted and ready to land.May 3 2021, 3:08 PM

Closed by commit rDWAPPS36740a0fd9b0: Save code now: Do not check origins for existence (authored by ardumont). · Explain WhyMay 3 2021, 3:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPS36740a0fd9b0: Save code now: Do not check origins for existence.