Differential D5591

Remove row locking from SQL queries
ClosedPublic
Actions

Authored by olasd on Apr 26 2021, 12:55 PM.

Details

Reviewers

ardumont

Commits

rDSCHbab557e9f669: Remove row locking from SQL queries

Summary

This would only be useful if we had multiple runners running
concurrently, but that's not the case.

Test Plan

tox

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Apr 26 2021, 12:55 PM

Build is green

Patch application report for D5591 (id=19989)

Rebasing onto f186910c43...

Current branch diff-target is up to date.

Changes applied before test

commit f8550885d0009c411d741531abbc8f03fddbfb29
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Apr 26 12:55:00 2021 +0200

    Remove row locking from SQL queries
    
    This would only be useful if we had multiple runners running
    concurrently, but that's not the case.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/334/ for more details.

Harbormaster completed remote builds in B20989: Diff 19989.Apr 26 2021, 12:58 PM

olasd requested review of this revision.Apr 26 2021, 12:58 PM

ardumont accepted this revision.Apr 26 2021, 2:13 PM

This revision is now accepted and ready to land.Apr 26 2021, 2:13 PM

Rebase

Build is green

Patch application report for D5591 (id=20208)

Rebasing onto feff1790e2...

Current branch diff-target is up to date.

Changes applied before test

commit bab557e9f669caa69bca8cac239ba460542857db
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Apr 26 12:55:00 2021 +0200

    Remove row locking from SQL queries
    
    This would only be useful if we had multiple runners running
    concurrently, but that's not the case.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/337/ for more details.

Harbormaster completed remote builds in B21198: Diff 20208.Apr 30 2021, 8:17 PM

Closed by commit rDSCHbab557e9f669: Remove row locking from SQL queries (authored by olasd). · Explain WhyApr 30 2021, 8:18 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSCHbab557e9f669: Remove row locking from SQL queries.