urls: Inverse legacy and new SWHID browse URLs in URL patterns
ClosedPublic
Actions

Authored by anlambert on Apr 19 2021, 6:52 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3234: Handle gracefully trailing slashes when resolving SWHID in search box

Commits

rDWAPPSc908051ca7ac: urls: Inverse legacy and new SWHID browse URLs in URL patterns

Summary

Legacy SWHID browse URLs were no more honored, new ones were used
instead resulting in SWHID validation errors.

See https://archive.softwareheritage.org/swh:1:rev:ad74f6a7f73c7906f9b36ee28dd006231f42552e;origin=https://gitlab.com/lemta-rheosol/craft-virtual-dma;visit=swh:1:snp:ef1a939275f05b667e189afbeed5fd59cca51c9d/

Bad @anlambert who did not add a test for this.

Related to T3234

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20857
Build 32366: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32365: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 19 2021, 6:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 19 2021, 6:52 PM

anlambert mentioned this in T3234: Handle gracefully trailing slashes when resolving SWHID in search box.Apr 19 2021, 6:53 PM

anlambert edited the summary of this revision. (Show Details)Apr 19 2021, 6:58 PM

Build is green

Patch application report for D5556 (id=19848)

Rebasing onto f3f1b7c84a...

Current branch diff-target is up to date.

Changes applied before test

commit 889318571d4550426821ab4106f9e1953263ad7a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 19 18:49:42 2021 +0200

    urls: Inverse legacy and new SWHID browse URLs in URL patterns
    
    Legacy SWHID browse URLs were no more honored, new ones were used
    instead resulting in SWHID validation errors.
    
    Related to T3234

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/693/ for more details.

Harbormaster completed remote builds in B20857: Diff 19848.Apr 19 2021, 7:00 PM

anlambert requested review of this revision.Apr 19 2021, 7:00 PM

ardumont accepted this revision.Apr 19 2021, 7:01 PM

This revision is now accepted and ready to land.Apr 19 2021, 7:01 PM

Update test, use swhid instead of legacy_swhid.

This revision was landed with ongoing or failed builds.Apr 19 2021, 7:05 PM

Closed by commit rDWAPPSc908051ca7ac: urls: Inverse legacy and new SWHID browse URLs in URL patterns (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSc908051ca7ac: urls: Inverse legacy and new SWHID browse URLs in URL patterns.

Build has FAILED

Patch application report for D5556 (id=19850)

Rebasing onto f3f1b7c84a...

Current branch diff-target is up to date.

Changes applied before test

commit c908051ca7ac2bfee6e374c3e6158d97525dd2e0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 19 18:49:42 2021 +0200

    urls: Inverse legacy and new SWHID browse URLs in URL patterns
    
    Legacy SWHID browse URLs were no more honored, new ones were used
    instead resulting in SWHID validation errors.
    
    Related to T3234

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/694/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/694/console

Harbormaster failed remote builds in B20859: Diff 19850!Apr 19 2021, 7:13 PM