Related to T3266
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T3266: Improve save code now failed/uneventful status reporting
- Commits
- rDWAPPS1042f73c181d: Add visit_status to SaveOriginRequest model
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- master
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 20917 Build 32461: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 32460: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5555 (id=19847)
Could not rebase; Attempt merge onto f3f1b7c84a...
Updating f3f1b7c8..5a0fa9e4 Fast-forward .../0009_saveoriginrequest_visit_status.py | 18 ++++++ swh/web/common/models.py | 2 + swh/web/common/origin_save.py | 35 ++++++++++- swh/web/tests/common/test_origin_save.py | 70 ++++++++++++++++++---- 4 files changed, 111 insertions(+), 14 deletions(-) create mode 100644 swh/web/common/migrations/0009_saveoriginrequest_visit_status.py
Changes applied before test
commit 5a0fa9e459da7a7b706852221be748471af55b47
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon Apr 19 18:26:33 2021 +0200
Add visit_status to SaveOriginrequest model
Related to T3266
commit d31ab3d188b567187f695dbb30d7513c77634657
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon Apr 19 17:56:06 2021 +0200
origin_save: Add docstring and some test scenarios
Related to T3266See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/692/ for more details.
Comment Actions
- Rebase
- Add migration script (and test it)
- Update test to ensure the visit status is correctly set
Comment Actions
Build has FAILED
Patch application report for D5555 (id=19853)
Could not rebase; Attempt merge onto c908051ca7...
Updating c908051c..7a830927 Fast-forward requirements-test.txt | 1 + .../0009_saveoriginrequest_visit_status.py | 32 +++++++++ swh/web/common/models.py | 18 ++++++ swh/web/common/origin_save.py | 36 ++++++++++- swh/web/tests/common/test_origin_save.py | 75 ++++++++++++++++++---- swh/web/tests/test_migrations.py | 23 +++++++ 6 files changed, 171 insertions(+), 14 deletions(-) create mode 100644 swh/web/common/migrations/0009_saveoriginrequest_visit_status.py create mode 100644 swh/web/tests/test_migrations.py
Changes applied before test
commit 7a8309275dfec2204adfad617e9f18371087aaf8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon Apr 19 18:26:33 2021 +0200
Add visit_status to SaveOriginRequest model
Related to T3266
commit 4a6d884a7449bf01c1ce8fda24ab6286fb887129
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon Apr 19 17:56:06 2021 +0200
origin_save: Add docstring and some test scenarios
Related to T3266Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/696/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/696/console
Comment Actions
Looks good to me.
I guess you will update and test the visit status in model objects once a visit has been found in another diff ?
Oh and you hit another cypress flaky test, this is not related to that diff.
| requirements-test.txt | ||
|---|---|---|
| 12 | Please keep lexicographical ordering. | |
Comment Actions
I guess you will update and test the visit status in model objects once a visit has been found in another diff ?
Yes, i'll do that now.
Between that and other tasks i'm dealing with you beat me to making that diff actually do something relevant with that new status ;)
| requirements-test.txt | ||
|---|---|---|
| 12 | sure | |
Comment Actions
Build is green
Patch application report for D5555 (id=19865)
Rebasing onto 4a6d884a74...
Current branch diff-target is up to date.
Changes applied before test
commit fb1f5bbd85137f0754435c10784d03aa41efd20e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon Apr 19 18:26:33 2021 +0200
Add visit_status to SaveOriginRequest model
Related to T3266See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/697/ for more details.
Comment Actions
Build is green
Patch application report for D5555 (id=19912)
Rebasing onto 015ddb8964...
Current branch diff-target is up to date.
Changes applied before test
commit 1042f73c181d722e681a562088afcdcc2ee0af69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Mon Apr 19 18:26:33 2021 +0200
Add visit_status to SaveOriginRequest model
Related to T3266See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/712/ for more details.