Page MenuHomeSoftware Heritage
Differential D5549

Deploy check save code now end to end check
ClosedPublic
Actions

Authored by ardumont on Apr 16 2021, 5:40 PM.

Details

Reviewers
vsellier
Group Reviewers
System administrators
Maniphest Tasks
T2117: Save Code Now: End to End monitoring
Commits
rSPSITEc20830858ae9: deposit e2e check: Fix variables typo
rSPSITEffe24c7f6dfd: Deploy check save code now end to end check
Summary

This will trigger as many checks as we reference in the entry
swh::deploy::savecodenow::e2e::origins.

Related to T2117

Test Plan

vagrant up staging-webapp still happy
bin/octocatalog-diff on pergamon/moma does not render anything

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont requested review of this revision.Apr 16 2021, 5:40 PM
ardumont created this revision.
Harbormaster completed remote builds in B20828: Diff 19816.Apr 16 2021, 5:40 PM
ardumont added inline comments.Apr 16 2021, 5:43 PM
data/common/common.yaml
1892

independent fix in a dedicated commit.

vsellier accepted this revision.Apr 16 2021, 6:00 PM
vsellier added a subscriber: vsellier.

just one question inline regarding the icinga test name.
Otherwise, looks good

site-modules/profile/manifests/icinga2/objects/e2e_checks_savecodenow.pp
25

Wouldn't adding the type be interesting if several (svn/hg) are launched ?

This revision is now accepted and ready to land.Apr 16 2021, 6:00 PM
ardumont added inline comments.Apr 16 2021, 6:01 PM
site-modules/profile/manifests/icinga2/objects/e2e_checks_savecodenow.pp
25

yes, i think you are right.
It crossed my mind and somehow got too lazy ;)

ardumont updated this revision to Diff 19817.Apr 16 2021, 6:11 PM

Adapt according to suggestion

Harbormaster completed remote builds in B20829: Diff 19817.Apr 16 2021, 6:11 PM
Closed by commit rSPSITEffe24c7f6dfd: Deploy check save code now end to end check (authored by ardumont). · Explain WhyApr 16 2021, 6:16 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rSPSITEffe24c7f6dfd: Deploy check save code now end to end check.
ardumont added a commit: rSPSITEc20830858ae9: deposit e2e check: Fix variables typo.

Revision Contents
Changeset List

PathSize
data/
common/
13 lines
deployments/
production/
4 lines
staging/
3 lines
site-modules/
profile/
manifests/
icinga2/
objects/
33 lines
swh/
deploy/
webapp/
11 lines

Diff 19818

View Options

data/common/common.yaml

Loading...
View Options

data/deployments/production/common.yaml

Loading...
View Options

data/deployments/staging/common.yaml

Loading...
View Options

site-modules/profile/manifests/icinga2/objects/e2e_checks_savecodenow.pp

Loading...
View Options

site-modules/profile/manifests/swh/deploy/webapp/icinga_checks.pp

Loading...
About · Developer information · Legal